Improve tests for MultipleFileUpload
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 55/100
- Issue 类型
- 重构
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- react, typescript
调研方向
从 MultipleFileUpload 组件及其现有的 snapshot 测试开始。检查第三方库的 onFileDrop 行为目前是如何表示的,然后为返回的 File 路径以及它与单文件上传之间的差异添加有针对性的覆盖。完成标准是相关行为得到了测试,而不仅仅是由 snapshots 覆盖。
由索引模型根据 Issue 内容生成。
描述
Describe the enhancement or change
Consumer reported the following:
Not really an issue, but I am puzzled by the slight behaviour change of the MultipleFileUpload component.
The onFileDrop callback sends an array of File objects, with properties like path. But it seems this propetrty
changed a little bit:
In PF5 I was getting for example: path: "image.png"
In PF6 I am getting: path: "./image.png"
That's not much of a change and is almost the same in a filesystem. But as I was using this info for the path of the object I am sending into Object Storage, it messed up my app a little bit.
Again, not an issue, I will handle it in my code, but I was wondering if there was a specific reason for this behaviour change? Which does not happen for single file upload btw, it's the plain name of the file only.
We use a third-party library for this piece of the component - we did bump from 14.2.3 to 14.3.5 between versions, so it's possible they changed the file name handling between versions. I don't see a big difference in our code. I do see that we have mostly snapshot tests for this component and do not test the third-party library functionality at all in our tests, so we wouldn't have caught this when we bumped the dependency. We could stand to improve our tests for this component in my opinion.
Is this request originating from a Red Hat product team? If so, which ones and is there any sort of deadline for this enhancement?
No - not blocking.
Jira Issue: PF-1855
- 主要语言
- TypeScript
- 星标
- 862
- 派生
- 392
- 平均合并
- 4 天 8 小时
- 30 天内合并 PR
- 9
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
patternfly/patternfly-react 的其他 Issue
-
PF Team
难度 2/5 1-3 小时 新手友好度 68/100
patternfly/patternfly-react#12651 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
patternfly/patternfly-react#12637 ·
-
PF Team
难度 2/5 1-3 小时 新手友好度 72/100
patternfly/patternfly-react#12617 · 1 条评论 ·
-
PF Team
难度 2/5 1-3 小时 新手友好度 68/100
patternfly/patternfly-react#12610 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 68/100
patternfly/patternfly-react#12600 ·
查看 patternfly/patternfly-react 的全部 Issue
相似的 Issue
-
难度 1/5 1-3 小时 新手友好度 88/100
motiondivision/motion#3849 ·
-
check:passed streams:add
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 68/100
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
i-am-bee/beeai-framework#1697 · 1 个 reaction ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 75/100
antfu/node-modules-inspector#214 ·