port_settings_apply clobbers link-local addresses added via link_ipv6_create
维护者通常 5 天内回复
@cfzimmerman 已经在做这个了。
开始于 2026年8月25日。
评估
这个 Issue 还没有评估数据。
描述
When port_settings_apply is run, it grabs a copy of dpd's internal state for each port/link, diffs it against the state requested by the API client, and then reconciles the difference.
The problem we have here is that omicron is the main (practically only) consumer of port_settings_apply, and it doesn't include any link-local IPv6 addresses in its request... since these are handled by tfportd and illumos.
tfportd learns about IPv6 link-local addresses in illumos from its reconciler, and synchronizes them into dpd via link_ipv6_create.
Both port_settings_apply and link_ipv6_create modify the same internal state: Link.ipv6
#[derive(Debug)]
pub struct Link {
pub port_id: PortId,
pub link_id: LinkId,
pub port_hdl: PortHdl,
pub asic_port_id: AsicId,
pub updated: i64,
pub presence: bool,
pub ipv6_enabled: bool,
pub tx_eq: Option<TxEq>,
pub fsm_state: asic::PortFsmState,
pub link_state: LinkState,
pub media: PortMedia,
/// A list of IPv4 addresses assigned to this link.
pub ipv4: BTreeSet<Ipv4Entry>,
/// A list of IPv6 addresses assigned to this link.
pub ipv6: BTreeSet<Ipv6Entry>, <<<<<<<<<<<
pub linkup_tracker: LinkUpTracker,
pub autoneg_tracker: AutonegTracker,
/// Configuration requested by the user/sled-agent.
pub config: LinkConfig,
/// State that actually exists in the ASIC layer.
pub(crate) plumbed: LinkPlumbed,
}
When port_settings_apply is run, the internal dpd state includes all items in Link.ipv6 (including the link-locals added by tfportd) and thus the diff always indicates that the link-local is old state that should be removed.
This results in the omicron reconciler (via port_settings_apply) and the tfport reconciler (via link_ipv6_create) battling each other and the IPv6 link-local addresses being removed from the ASIC anytime omicron's reconciler runs after the tfport reconciler... which means that periodically, the ASIC will stop punting traffic destined for that link-local address. This would affect NDP, BGP unnumbered, etc. and could potentially cause service disruptions if the blackholing were to last long enough.
- 主要语言
- Rust
- 星标
- 20
- 派生
- 3
- 平均合并
- 8 小时 29 分钟
- 30 天内合并 PR
- 2
环境准备
我们还没有检查这个项目的环境配置文件。先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
oxidecomputer/dendrite 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
oxidecomputer/dendrite#380 ·
维护者通常 5 天内回复
-
难度 3/5 1-2 天 新手友好度 65/100
oxidecomputer/dendrite#375 ·
维护者通常 5 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
oxidecomputer/dendrite#369 ·
维护者通常 5 天内回复
-
难度 3/5 1-2 天 新手友好度 58/100
oxidecomputer/dendrite#368 ·
维护者通常 5 天内回复
-
难度 4/5 3-5 天 新手友好度 52/100
oxidecomputer/dendrite#359 · 1 条评论 ·
维护者通常 5 天内回复
查看 oxidecomputer/dendrite 的全部 Issue
相似的 Issue
-
area:casework bug criticality:p3 triage:needs-implementation
难度 2/5 1-3 小时 新手友好度 84/100
registrystack/registry-stack#1623 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
leptos-rs/leptos#4885 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
longbridge/gpui-kit#3276 ·
维护者通常 1 天内回复
-
A-Migration Guides D-Straightforward S-Ready-For-Implementation X-Uncontroversial
难度 1/5 1 小时以内 新手友好度 88/100
bevyengine/bevy-website#2607 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复