[FEATURE REQUEST] Review `avoidScreenshotsIfNeeded` usage

未关闭
#4,996 2 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@joragua 已经在做这个了。

开始于 2026年10月8日。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
android, kotlin
领域
mobile

调研方向

Start by locating every use of avoidScreenshotsIfNeeded and reviewing the dialogs where it is called, including remove-share and remove-member dialogs. Done means each use has been assessed and unnecessary calls are removed; add unit tests if needed and verify the resulting behavior with the stated QA test plan.

由索引模型根据 Issue 内容生成。

描述

Estimation - 2 (S) Feature request Needs info Technical
fun Dialog.avoidScreenshotsIfNeeded() {
    if (!BuildConfig.DEBUG && context.resources?.getBoolean(R.bool.allow_screenshots) == false) {
        window?.addFlags(WindowManager.LayoutParams.FLAG_SECURE)
    }

such method is used in several dialogs across the app. Some of them (like the remove share or remove member from space) do not seem to need to avoid screenshots

All the uses of the method should be reviewed to keep those that are really useful, and remove the ones that don't need avoidScreenshotsIfNeeded

TASKS
  • Research (if needed)
  • Create branch technical/remove_avoid_screenshots_method_from_dialogs
  • Development tasks
    • Implement whatever
    • ...
    • Implement unit tests (if needed)
  • Code review and apply changes requested
  • Design test plan
  • QA
  • Merge branch technical/remove_avoid_screenshots_method_from_dialogs into master
主要语言
Kotlin
星标
4.2k
派生
3.1k
平均合并
3 天 9 小时
30 天内合并 PR
16

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

owncloud/android 的其他 Issue

查看 owncloud/android 的全部 Issue

相似的 Issue

更多 Kotlin Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。