Another legacy NumberWithUnits issue.

未关闭
#1,311 4 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 4 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
perl
领域
backend

调研方向

The bug is that calling Real($student) on a NumberWithUnits answer inside a custom cmp checker still returns a NumberWithUnits instead of a Real. Start by reproducing it with the checker in Library/Michigan/Chap2Sec1/Q17.pg, then find where Real() and the NumberWithUnits class are defined in the Perl sources. Done means the checker's range test works on the student's numeric value, and you know whether Real() should change or the problem should use ->value, which the reporter used as a workaround.

由索引模型根据 Issue 内容生成。

描述

This was observed for the problem Library/Michigan/Chap2Sec1/Q17.pg. That problem uses a custom checker for the second answer in the problem. The checker tries to convert the student unit answer to a MathObject Real by calling Real($student). I think that used to result in a MathObject Real at least, but now it is still a NumberWithUnits. The checker in the problem is:

ANS(
    NumberWithUnits($v, "ft/s")->cmp(
        checker => sub {
            my ($correct, $student, $ansHash) = @_;
            $stu_real = Real($student);
            if ($min <= $stu_real && $stu_real <= $max) {
                return 1;
            } else {
                return 0;
            }
        }
    )
);

In any case, the correct answer is not accepted anymore. It worked for previous versions of PG. I have changed the call to $stu_readl = $student->value on my server which works, but this is a problem that most likely is used elsewhere.

主要语言
Perl
星标
48
派生
78
平均合并
5 天 13 小时
30 天内合并 PR
9

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

openwebwork/pg 的其他 Issue

查看 openwebwork/pg 的全部 Issue

相似的 Issue

更多 Perl Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。