NoGuava Recipe – Summary of the analysis on the Sirius-Desktop codebase
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
从附带的 minimal-app 示例开始，尤其是 GuavaConversionSamples_AllOK 和 GuavaConversionSamples，并阅读每个类中的 Javadoc 以了解所述的验证步骤。针对 NoGuava recipe 运行文档中记录的 Maven 命令，并比较已处理的案例和剩余案例；该 issue 未定义具体的更改或完成标准。
由索引模型根据 Issue 内容生成。
描述
This ticket is not really a bug report, but rather a summary of the tests and fixes I’ve made regarding the NoGuava recipe, based on the Sirius-Desktop codebase.
I started this analysis about two weeks ago. At that time, the version of rewrite-migrate-java I used was v3.19.0. Running the migration resulted in around 437 compilation errors.
After several issues and PRs (thanks to @timtebeek), I now get down to around 179 compilation errors.
Most of these remaining errors come from cases that are not yet handled, including some that are difficult to support because doing so could impact performance (there’s no direct Java equivalent).
To make my analysis easier (and faster), I created a minimal example, minimal-app, containing all the test cases used in the NoGuava recipes, as well as the remaining unhandled cases - with the goal of getting as close as possible to 100% coverage on the Sirius-Desktop codebase. This minimal example may be useful to others as well, so I’m attaching it here: minimal-app.zip.
For the moment, I think I'll leave it at that.
What version of OpenRewrite are you using?
Initially I was using:
- Maven v3.9.5
- Rewrite Maven Plugin v6.21.1
- org.openrewrite.recipe:rewrite-migrate-java v3.19.0
And now, I am using:
- Maven v3.9.5
- Rewrite Maven Plugin v6.23.0
- org.openrewrite.recipe:rewrite-migrate-java v3.21.0
How are you running OpenRewrite?
I used the Maven command line to launch the recipe on the minimal-app sample :
mvn -U org.openrewrite.maven:rewrite-maven-plugin:6.23.0-SNAPSHOT:run \
-Drewrite.recipeArtifactCoordinates=org.openrewrite.recipe:rewrite-migrate-java:3.21.0-SNAPSHOT \
-Drewrite.activeRecipes=org.openrewrite.java.migrate.guava.NoGuava \
-Drewrite.exportDatatables=true \
-Dmaven.repo.local=./.repositoryMaven
You may need to update the versions depending on the current SNAPSHOT version.
What is the smallest, simplest way to reproduce the problem?
This minimal example, minimal-app, includes two classes:
GuavaConversionSamples_AllOK: Contains all the handled cases and helps ensure there are no regressions overall.GuavaConversionSamples: Contains the same cases as above, plus all those still producing errors.
What did you expect to see?
The expected outcome and the verification steps to perform after the migration are detailed in the Javadoc of each class.
- 主要语言
- Java
- 星标
- 159
- 派生
- 130
- 平均合并
- 6 小时 49 分钟
- 30 天内合并 PR
- 47
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
openrewrite/rewrite-migrate-java 的其他 Issue
-
bug
难度 4/5 3-5 天 新手友好度 68/100
openrewrite/rewrite-migrate-java#1246 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 32/100
openrewrite/rewrite-migrate-java#1227 · 2 条评论 ·
维护者通常 1 天内回复
-
OptionalNotPresentToIsEmpty rewrites `!isPresent()` on a non-`java.util.Optional` type, producing uncompilable `isEmpty()`可能重新可做 关联的 PR 已关闭且未合并。 未关闭
难度 3/5 1-2 天 新手友好度 70/100
openrewrite/rewrite-migrate-java#1146 · 3 条评论 ·
维护者通常 1 天内回复
-
bug
难度 4/5 3-5 天 新手友好度 50/100
openrewrite/rewrite-migrate-java#1119 · 5 条评论 ·
维护者通常 1 天内回复
-
bug
难度 4/5 3-5 天 新手友好度 45/100
openrewrite/rewrite-migrate-java#1069 · 2 条评论 ·
维护者通常 1 天内回复
查看 openrewrite/rewrite-migrate-java 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
-
bug
难度 1/5 1 小时以内 新手友好度 88/100
PhasetransCrystal/FPSMatch#47 ·
维护者通常 1 天内回复
-
bug
难度 1/5 1 小时以内 新手友好度 76/100
apache/maven-toolchains-plugin#205 · 1 条评论 ·
维护者通常 2 天内回复
-
难度 1/5 1 小时以内 新手友好度 90/100
维护者通常 1 天内回复
-
[Bug] Dated CSV export filenames use the UTC day rather than the operator day可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
apache/rocketmq-dashboard#6896 ·
维护者通常 3 天内回复