Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

UseMapOf: Skip refactoring large maps to Map.ofEntries to prevent javac compiler hangs (add maxEntries option)

未关闭
#1,310 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
55/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
java
领域
backend

调研方向

Start with src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java and its tests in src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java; read how the recipe collects put statements for both initialization patterns. Check the existing tests and add coverage for a configurable entry limit, including maps just above and at the limit. Done when oversized maps are skipped and maps within the configured limit still rewrite as expected.

由索引模型根据 Issue 内容生成。

描述

bug

I checked out all relevant OpenRewrite repo's, fed the AI with existing recipe name and a very careful description. Antigravity with Vertex / Gemini was then tasked to check and test. .Also to create a ticket for it, using your default template. The result is shown beneath.

UseMapOf: Skip refactoring large maps to Map.ofEntries to prevent javac compiler hangs (add maxEntries option)

What version of OpenRewrite are you using?

I am using:

  • OpenRewrite v8.93.0
  • rewrite-maven-plugin v6.50.0

How are you running OpenRewrite?

I am using the Maven plugin in a multi-module project:

What is the smallest, simplest way to reproduce the problem?

When refactoring large static lookup maps (e.g. >50–100 entries):

import java.util.HashMap;
import java.util.Map;

class LargeLookup {
    private static final Map<String, Integer> CODE_MAP = new HashMap<>();
    static {
        CODE_MAP.put("k1", 1);
        CODE_MAP.put("k2", 2);
        // ... 150+ more entries
        CODE_MAP.put("k150", 150);
    }
}

What did you expect to see?

Either:

  1. Maps exceeding a reasonable size threshold (e.g. 50 entries) are left as HashMap.put(..) statements, or
  2. An optional configuration parameter (e.g. maxEntries, default 50) allows capping the recipe threshold.

What did you see instead?

UseMapOf converts the sequence into:

private static final Map<String, Integer> CODE_MAP = new HashMap<>(Map.ofEntries(
    Map.entry("k1", 1),
    Map.entry("k2", 2),
    // ... 150+ varargs entries
));

With 100+ generic Map.entry(..) varargs arguments, javac generic type inference suffers exponential slowdowns during compilation (com.sun.tools.javac.comp.Attr), causing downstream builds and CI pipelines to hang or time out.

What is the full stack trace of any errors you encountered?

N/A (Compilation hang in downstream javac, not an exception thrown by OpenRewrite).

Proposed Fix & Tested Patch

Add an optional @Option parameter maxEntries (default 50) to UseMapOf to guard both anonymous-class and prose-pattern initializations.

Below is a tested, self-contained git patch against openrewrite/rewrite-migrate-java (tested locally with 100% green test suite):

diff --git a/src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java b/src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java
--- a/src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java
+++ b/src/main/java/org/openrewrite/java/migrate/util/UseMapOf.java
@@ -18,6 +18,8 @@ package org.openrewrite.java.migrate.util;
 import lombok.Getter;
+import org.jspecify.annotations.Nullable;
 import org.openrewrite.ExecutionContext;
+import org.openrewrite.Option;
 import org.openrewrite.Preconditions;
 import org.openrewrite.Recipe;
@@ -35,6 +37,7 @@ public class UseMapOf extends Recipe {
     private static final MethodMatcher MAP_PUT = new MethodMatcher("java.util.Map put(..)", true);
 
     private static final String PROSE_REWRITES_KEY = "use-map-of.prose-rewrites";
+    private static final int DEFAULT_MAX_ENTRIES = 50;
+
+    @Option(displayName = "Maximum entries",
+            description = "The maximum number of entries to convert into `Map.of(..)` or `Map.ofEntries(..)`. " +
+                    "Maps containing more entries than this threshold will not be refactored, " +
+                    "preventing javac generic type inference compiler hangs and excessive varargs allocations. Defaults to 50.",
+            example = "50",
+            required = false)
+    @Nullable
+    Integer maxEntries;
 
     @Getter
     final String displayName = "Prefer `Map.of(..)`";
@@ -49,6 +52,14 @@ public class UseMapOf extends Recipe {
             "- A `new HashMap<>()` declaration followed by a chain of `target.put(k, v)` statements, " +
             "which is collapsed to `new HashMap<>(Map.of(..))` (or `new HashMap<>(Map.ofEntries(..))`) — " +
             "preserving the mutable `HashMap`.";
 
+    public UseMapOf() {
+        this(null);
+    }
+
+    public UseMapOf(@Nullable final Integer maxEntries) {
+        this.maxEntries = maxEntries;
+    }
+
     @Override
     public TreeVisitor<?, ExecutionContext> getVisitor() {
@@ -118,6 +129,10 @@ public class UseMapOf extends Recipe {
                                 if (isAssignedToConcreteHashMap()) {
                                     return n;
                                 }
                                 List<Statement> putStatements = ((J.Block) statement).getStatements();
+                                final int limit = maxEntries != null ? maxEntries : DEFAULT_MAX_ENTRIES;
+                                if (putStatements.size() > limit) {
+                                    return n;
+                                }
                                 List<Expression> args = new ArrayList<>();
@@ -321,7 +336,8 @@ public class UseMapOf extends Recipe {
                                     break;
                                 }
                             }
-                            if (puts.size() >= 2 && initializer != null) {
+                            final int limit = maxEntries != null ? maxEntries : DEFAULT_MAX_ENTRIES;
+                            if (puts.size() >= 2 && puts.size() <= limit && initializer != null) {
                                 rewrites.put(initializer.getId(), puts);
                                 absorbedPutIds.addAll(absorbedHere);
                                 i = j;
diff --git a/src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java b/src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java
--- a/src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java
+++ b/src/test/java/org/openrewrite/java/migrate/util/UseMapOfTest.java
@@ -574,4 +574,86 @@ class UseMapOfTest implements RewriteTest {
           )
         );
     }
+
+    @Test
+    void customMaxEntriesThresholdHonored() {
+        //language=java
+        rewriteRun(
+          spec -> spec.recipe(new UseMapOf(3)),
+          java(
+            """
+              import java.util.HashMap;
+              import java.util.Map;
+
+              class Test {
+                  void m() {
+                      Map<String, Integer> map = new HashMap<>();
+                      map.put("k1", 1);
+                      map.put("k2", 2);
+                      map.put("k3", 3);
+                      map.put("k4", 4);
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Test
+    void customMaxEntriesWithinThresholdRewritten() {
+        //language=java
+        rewriteRun(
+          spec -> spec.recipe(new UseMapOf(3)),
+          java(
+            """
+              import java.util.HashMap;
+              import java.util.Map;
+
+              class Test {
+                  void m() {
+                      Map<String, Integer> map = new HashMap<>();
+                      map.put("k1", 1);
+                      map.put("k2", 2);
+                      map.put("k3", 3);
+                  }
+              }
+              """,
+            """
+              import java.util.HashMap;
+              import java.util.Map;
+
+              class Test {
+                  void m() {
+                      Map<String, Integer> map = new HashMap<>(Map.of(
+                              "k1", 1,
+                              "k2", 2,
+                              "k3", 3));
+                  }
+              }
+              """
+          )
+        );
+    }
+
+    @Test
+    void proseExceedsDefaultMaxEntriesNotRewritten() {
+        final StringBuilder puts = new StringBuilder();
+        for (int i = 0; i < 51; i++) {
+            puts.append("        map.put(\"k").append(i).append("\", ").append(i).append(");\n");
+        }
+        //language=java
+        rewriteRun(
+          java(
+            "import java.util.HashMap;\n" +
+            "import java.util.Map;\n\n" +
+            "class Test {\n" +
+            "    void m() {\n" +
+            "        Map<String, Integer> map = new HashMap<>();\n" +
+            puts +
+            "    }\n" +
+            "}\n"
+          )
+        );
+    }
 }
主要语言
Java
星标
160
派生
133
平均合并
7 小时 49 分钟
30 天内合并 PR
60

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

openrewrite/rewrite-migrate-java 的其他 Issue

查看 openrewrite/rewrite-migrate-java 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。