refactor: split MainContent into per-concern hooks
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 55/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 冷清
- 技术栈
- react, typescript
调研方向
Start with src/components/layout/MainContent.tsx and choose one listed extraction: useEditorTabs(), useQueryExecution(), usePsqlSession() (around lines 580–700), or the toolbar component. Read the relevant state and call sites, then add a Vitest test for one path and run the TypeScript checks, tests, and build. Done means the extracted module owns its concern, the parent passes data through props, and app behavior remains unchanged.
由索引模型根据 Issue 内容生成。
描述
src/components/layout/MainContent.tsx is 2,474 lines — by far the largest component in the app. It manages editor tabs, query execution, the integrated psql shell, results state, tool buttons, AI assist, compare/clone/definition modals, and history navigation. New contributors hit this file first and bounce.
What to extract
Any one of these is a complete, mergeable PR:
useEditorTabs()— tab state, switching, persistence, the+button.useQueryExecution()—executeQuery, the active execution state, cancellation, history-writing.usePsqlSession()— CLI path detection,\chandling,cliExecStmt, the psql output buffer. Roughly lines 580–700.<Toolbar>— the top button strip (Save, Format, Run, Tools, AI, Compare, Clone, etc.) as a sub-component.
Suggested approach
- Hooks live in
src/hooks/editor/(new directory). - Sub-components live next to
MainContent.tsx(src/components/layout/). - Aim to remove ~300–500 lines from MainContent.tsx per PR. Stop there; don't try to refactor everything in one shot.
Done criteria
- Behavior unchanged when running the app manually.
- The extracted hook/component is the only thing that owns its concern — the parent passes data down via props, not via in-line state.
- TypeScript clean, tests clean, build clean.
- Add a Vitest test exercising at least one path of the new module.
Out of scope
- Replacing Zustand with Redux/TanStack Query.
- Reworking the panel-resize layout.
- Touching the results grid logic (covered in a future ticket).
Audit reference
K2 in the pre-launch audit.
- 主要语言
- TypeScript
- 星标
- 6
- 派生
- 1
- 平均合并
- 17 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
openidle-dev/queryden 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
openidle-dev/queryden#240 ·
-
bug enhancement
难度 2/5 1-3 小时 新手友好度 76/100
openidle-dev/queryden#187 ·
-
难度 2/5 1-3 小时 新手友好度 58/100
openidle-dev/queryden#237 ·
-
难度 4/5 3-5 天 新手友好度 55/100
openidle-dev/queryden#192 ·
-
dependencies
难度 2/5 1-3 小时 新手友好度 58/100
openidle-dev/queryden#186 ·
查看 openidle-dev/queryden 的全部 Issue
相似的 Issue
-
Mend: dependency security vulnerability
难度 1/5 1-3 小时 新手友好度 65/100
fdm-monster/fdm-monster#5563 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
be-BOP-io-SA/be-BOP#2849 ·
-
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
1️⃣ phase/under-investigation flaky/confirmed flaky/needs-decision type/bug
难度 2/5 1-3 小时 新手友好度 65/100
growilabs/growi#12246 · 3 条评论 ·
维护者通常 1 天内回复
-
🐛 The Rulekeeper - An index run that gives up on the lock ends Succeeded可能已有人在做 @github-actions 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
SSWConsulting/SSW.Rules#2809 · 1 条评论 ·
维护者通常 1 天内回复