Property name 'full_name' should be spelled 'fullname' without underscores

未关闭
#282 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 5 天内回复

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
42/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
python

调研方向

从 auth_backends/backends.py 第 12 行开始,检查 JWT claim 如何映射到注册数据中。确认注册管道使用的拼写,并验证更正后的名称会填充注册字段,以便首次使用 SSO 的用户无需确认表单即可继续。

由索引模型根据 Issue 内容生成。

描述

Hello,

I believe there is a spelling error at the file auth_backends/backends.py, line 12

I think it should be written 'fullname' without underscores, and not 'full_name'.

This is used for mapping the claims provided in the JWT returned by the OAuth authorization code grant flow, but the name 'full_name' is not recognized at the 'registration' part of the pipeline, which in turn leaves the corresponding registration field empty, making it impossible to proceed with a SSO without the user confirming the registration form (in the case it's the first time a user gets registered in by means of third party SSO).

Changing it into 'fullname' makes this work.

Tested using a production environment using the "auth_backends.backends.EdXOAuth2" backend used for SSO of LMS with a custom OAuth2 identity provider.

I don't know if it was the original purpose, but I found this implementation to be very useful to be used for SSO with a generic third party OAuth2 Identity Provider implemented in house (not one of those well known public providers already listed in python-social-auth).

主要语言
Python
星标
24
派生
24
平均合并
3 天 21 小时
30 天内合并 PR
6

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

openedx/auth-backends 的其他 Issue

查看 openedx/auth-backends 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。