A spreadsheet prints at its own width, so a wide one is cut off on the right
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with PrintingManager.print and PageView in the Android app to see how the print job and its PrintAttributes are built, then read document_element.cpp where .odr-sheet and translate_table_column_style fix the table width in centimetres, plus the @media print rule in odrcore's stylesheet that forces zoom:1. Decide whether to scale from the app side (mirroring suspendDarkening) or add a print stylesheet in the shared renderer, and note the <thead> ruler as optional to hide. Done means a wide sheet prints scaled to the page width instead of being clipped, verified through the app's print path or WebView print preview.
由索引模型根据 Issue 内容生成。
描述
Reported by a user: a one-page .ods opens and displays correctly, but printing it from the phone comes out too wide and is cut off along the right edge. The same file prints correctly from a desktop. They were explicit that it is a minor annoyance for them.
Reproduced in the code rather than on paper, but the path is unambiguous.
Why it happens
A sheet is laid out at an absolute width. document_element.cpp writes each spreadsheet as a <table class="odr-sheet"> with one <col> per column carrying the document's own column width as both width and min-width (translate_table_column_style), and .odr-sheet is table-layout:fixed. The table is therefore exactly as wide as the document says, in centimetres, no matter what it is rendered onto.
On screen that is invisible, because PageView sets useWideViewPort and loadWithOverviewMode, so the WebView zooms out until the sheet fits. The core also applies a body zoom of its own.
On paper the zoom is deliberately removed. The core's stylesheet ends with
@media print{:root{--odr-zoom:1!important}body{zoom:1!important}}
commented "paper has its own geometry; beats the script's inline zoom" — which is right as far as it goes, but nothing then fits the sheet to that geometry. PrintingManager.print hands webView.createPrintDocumentAdapter() to the framework with a default PrintAttributes, and neither the app nor the core ships any other @media print rule. So the sheet is rendered at its natural width against the printable page width, and whatever does not fit is clipped.
A desktop office suite scales or paginates a sheet to the paper instead, which is why the same file is fine from a PC.
Scope
- Spreadsheets, and any other document wider than the page. Text documents are unaffected in practice because they are laid out to a page width already.
- PDFs are unaffected: they print through
PdfDocumentAdapter, not the WebView. - The "page margins" toggle cannot help here —
PaginationSettingis odrcore'stextDocumentMargin, which by its own documentation applies to text documents only.
Where a fix could go
Either side, and worth deciding deliberately:
- In the app, by asking for a page size that fits the content, or by scaling the WebView for the duration of the print job the way dark mode is already suspended for it (
suspendDarkening). - In odrcore, by giving
.odr-sheeta print stylesheet that scales the sheet down to the page, or breaks it across pages the way a spreadsheet application would.
The second is the more correct fix and helps every frontend, but it is a change to the shared renderer, so it needs its own decision.
Worth noting while in here
The printed page also carries the row and column ruler — the gutter and the A/B/C header row that document_element.cpp writes into <thead>. A spreadsheet application does not print those by default, and they add width to a page that has none to spare.
- 主要语言
- Kotlin
- 星标
- 473
- 派生
- 44
- 平均合并
- 3 小时 7 分钟
- 30 天内合并 PR
- 49
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
opendocument-app/OpenDocument.droid 的其他 Issue
-
UI
难度 2/5 1-3 小时 新手友好度 68/100
opendocument-app/OpenDocument.droid#724 ·
维护者通常 1 天内回复
-
UI
难度 1/5 1 小时以内 新手友好度 66/100
opendocument-app/OpenDocument.droid#723 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 64/100
opendocument-app/OpenDocument.droid#484 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 55/100
opendocument-app/OpenDocument.droid#725 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 58/100
opendocument-app/OpenDocument.droid#722 ·
维护者通常 1 天内回复
查看 opendocument-app/OpenDocument.droid 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
navikt/mock-oauth2-server#1129 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 77/100
-
unconfirmed
难度 2/5 1-3 小时 新手友好度 65/100
thunderbird/thunderbird-android#11778 · 2 条评论 ·
维护者通常 1 天内回复
-
bug
难度 1/5 1 小时以内 新手友好度 88/100
software-mansion/enriched-markdown#1042 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
world-federation-of-advertisers/cross-media-measurement#4709 ·
维护者通常 1 天内回复