tool_choice naming a function tool called web_search, file_search, mcp, etc. selects the built-in tool instead
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
从 src/agents/models/openai_responses.py 中的 Converter.convert_tool_choice 开始,那里像 web_search 这样的内置工具名称会在命名函数分支之前被映射,并与现有的 shell 和 apply_patch 判断进行比较。使用 httpx2 MockTransport 运行 issue 中的复现步骤,确认 tool_choice 被发送为 {'type': 'web_search'},而请求中的 tools 只包含函数。完成标准是:配置一个名为 web_search 的函数工具时得到 {'type': 'function', 'name': 'web_search'};没有 tools 或配置了 WebSearchTool 时仍返回内置选择器;并且 tests/models 通过。
由索引模型根据 Issue 内容生成。
描述
Please read this first
- Have you read the docs? Yes
- Have you searched for related issues? Yes. #4952 fixed this for
shellandapply_patch, andcomputerandtool_searchare already gated with tests. The other built-in names were left out.
Describe the bug
An agent on the Responses API has a function tool whose name matches a built-in tool type, for example its own web_search backed by another search API. Setting ModelSettings(tool_choice="web_search") to force that tool sends tool_choice={"type": "web_search"}, which selects the hosted web search tool, instead of {"type": "function", "name": "web_search"}. The request's tools list contains only the function, so the caller's tool can't be forced. The same happens for file_search, web_search_preview, computer_use_preview (with no ComputerTool), image_generation, code_interpreter, mcp and programmatic_tool_calling.
#4952 described exactly this for shell and apply_patch: without a gate, "a function tool named shell or apply_patch would silently stop being targetable".
Debug information
- Agents SDK version:
main(e355d69), also 0.24.0 - Related library versions: openai 3.29.0
- Python version: 3.14.7
- Operating system: macOS
- Model and model provider: OpenAI Responses API
- Does the issue reproduce with the latest Agents SDK release? Yes
- Does the issue occur consistently or intermittently? Consistently
Repro steps
A real AsyncOpenAI client on an httpx2.MockTransport, printing what's sent:
import asyncio, json
import httpx2
from openai import AsyncOpenAI
from agents import Agent, ModelSettings, OpenAIResponsesModel, RunConfig, Runner, function_tool
def handler(request: httpx2.Request) -> httpx2.Response:
body = json.loads(request.content)
print("tools sent :", [(t["type"], t.get("name")) for t in body["tools"]])
print("tool_choice sent:", body["tool_choice"])
return httpx2.Response(200, json={
"id": "resp_1", "object": "response", "created_at": 0, "model": "gpt-4.1",
"status": "completed", "parallel_tool_calls": True, "tool_choice": "auto", "tools": [],
"output": [{"type": "message", "id": "msg_1", "role": "assistant", "status": "completed",
"content": [{"type": "output_text", "text": "ok", "annotations": []}]}],
})
@function_tool(name_override="web_search")
def my_search(query: str) -> str:
"""Search my own index."""
return "result"
async def main() -> None:
client = AsyncOpenAI(api_key="x", http_client=httpx2.AsyncClient(transport=httpx2.MockTransport(handler)))
agent = Agent(name="a", tools=[my_search], model=OpenAIResponsesModel("gpt-4.1", client),
model_settings=ModelSettings(tool_choice="web_search"))
await Runner.run(agent, "find docs", run_config=RunConfig(tracing_disabled=True))
asyncio.run(main())
tools sent : [('function', 'web_search')]
tool_choice sent: {'type': 'web_search'}
Expected behavior
tool_choice is {"type": "function", "name": "web_search"} whenever a function tool (or handoff) with that name is configured, as already happens for shell, apply_patch, computer and tool_search.
Root cause and a possible fix
Converter.convert_tool_choice maps these strings to built-in selectors before the named-function branch and doesn't look at the configured tools (openai_responses.py#L1856-L1894). The shell/apply_patch branches are gated (#L1895-L1902). The gate below checks that a local function tool with that name exists, not that the built-in is configured, so prompt-managed built-in tools (#1304) keep working:
--- a/src/agents/models/openai_responses.py
+++ b/src/agents/models/openai_responses.py
+# Strings that convert_tool_choice maps to a built-in tool selector without checking
+# whether that built-in tool is configured.
+_HOSTED_TOOL_CHOICE_NAMES = frozenset(
+ {
+ "programmatic_tool_calling",
+ "file_search",
+ "web_search",
+ "web_search_preview",
+ "computer_use_preview",
+ "image_generation",
+ "code_interpreter",
+ "mcp",
+ }
+)
@@ class Converter:
elif tool_choice == "none":
return "none"
+ elif tool_choice in _HOSTED_TOOL_CHOICE_NAMES and cls._has_top_level_function_named(
+ tool_choice, tools=tools, handoffs=handoffs
+ ):
+ # Like computer, shell and apply_patch, a function tool with a built-in tool's
+ # name must stay targetable.
+ return {"type": "function", "name": tool_choice}
elif tool_choice == "programmatic_tool_calling":
@@ class Converter:
+ @classmethod
+ def _has_top_level_function_named(
+ cls,
+ name: str,
+ *,
+ tools: Sequence[Tool] | None,
+ handoffs: Sequence[Handoff[Any, Any]] | None,
+ ) -> bool:
+ return any(handoff.tool_name == name for handoff in handoffs or ()) or any(
+ isinstance(tool, FunctionTool)
+ and tool.name == name
+ and get_explicit_function_tool_namespace(tool) is None
+ and not tool.defer_loading
+ for tool in tools or ()
+ )
With the patch, the repro sends {'type': 'function', 'name': 'web_search'}. With no tools, or with a configured WebSearchTool(), "web_search" still maps to {'type': 'web_search'}. tests/models passes (1023 passed, 1 skipped).
- 主要语言
- Python
- 星标
- 30.4k
- 派生
- 4.9k
- 平均合并
- 16 小时 32 分钟
- 30 天内合并 PR
- 85
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
openai/openai-agents-python 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
openai/openai-agents-python#5477 ·
维护者通常 1 天内回复
-
Voice: default sentence splitter never splits Chinese/Japanese, so TTS waits for the whole reply未关闭
难度 2/5 1-3 小时 新手友好度 78/100
openai/openai-agents-python#5475 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
openai/openai-agents-python#5471 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
openai/openai-agents-python#5468 · 1 条评论 ·
维护者通常 1 天内回复
-
Docs: `tool_choice="required"` can select a state-changing tool when the needed one is not shown未关闭
难度 1/5 1 小时以内 新手友好度 90/100
openai/openai-agents-python#5461 · 1 条评论 ·
维护者通常 1 天内回复
查看 openai/openai-agents-python 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
enhancement good first issue
难度 2/5 1-3 小时 新手友好度 78/100
elviskahoro/sdk-python-attio#144 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
RenyiELBO raises TypeError when model has no sample sites可能已有人在做 @alibb007 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
维护者通常 1 天内回复