CI boundary checker misses renamed codex-core dependencies in codex-tui
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 76/100
调研方向
从 .github/scripts/verify_tui_core_boundary.py 开始，重点查看 manifest_failures() 和 source_failures()，然后检查 .github/workflows/repo-checks.yml 如何调用检查器。为常规依赖项表和特定目标依赖项表中的重命名依赖项添加回归测试，并验证检查器会拒绝这些依赖项，同时仍接受允许的清单。
由索引模型根据 Issue 内容生成。
描述
Summary
.github/scripts/verify_tui_core_boundary.py checks only whether the literal key codex-core appears in the Cargo dependency tables. Cargo permits renaming a dependency while preserving its underlying package name, so the checker accepts a direct dependency on codex-core if it is declared under an alias.
Source evidence
In manifest_failures(), the condition is if FORBIDDEN_PACKAGE in dependencies:. This tests dependency keys, not the package field of dependency specifications. source_failures() likewise looks for the literal codex_core identifier and misses imports using the alias.
Minimal reproduction (isolated Python, matching the current parser/check logic)
[dependencies]
core_alias = { package = "codex-core", path = "../core" }
With this dependency table, manifest_failures() returns []; with codex-core = { path = "../core" } it reports a failure. A Rust import use core_alias::... also avoids the hard-coded source patterns. This is a valid Cargo renamed-dependency form.
Expected
The CI check should reject any dependency whose key is codex-core or whose dependency table has package = "codex-core", including target-specific and dev/build dependencies.
Actual
The checker reports no violation for a renamed direct dependency, despite its stated purpose of enforcing the codex-tui → codex-core boundary. The check is invoked from .github/workflows/repo-checks.yml.
Suggested fix
Inspect each dependency entry's package field when the value is a table, and add a regression test for renamed direct dependencies and target-specific renamed dependencies. Consider token-aware source analysis separately to avoid false positives in comments.
Validation scope
Confirmed with an isolated Python reproduction of the exact TOML parsing and membership condition from the referenced source. No full Bazel/Cargo build was run. Reviewed source at commit e742db9f7ba98e63e502b310857d49d047888518; searched existing issues/PRs for this checker and found no exact duplicate.
- 主要语言
- Rust
- 星标
- 131k
- 派生
- 20.7k
- 平均合并
- 1 分钟
- 30 天内合并 PR
- 997
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
openai/codex 的其他 Issue
-
app bug
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 1 天内回复
-
app bug
难度 1/5 1 小时以内 新手友好度 65/100
维护者通常 1 天内回复
-
Package archive builder deletes existing file with unsupported suffix under --force可能已有人在做 @akhil9tiet 于 1 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
readme_toc.py generates duplicate fragment links for repeated headings可能已有人在做 @akhil9tiet 于 2 天前认领。 未关闭bug
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
CLI enhancement TUI
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
相似的 Issue
-
good first issue help wanted r-docs
难度 2/5 1-3 小时 新手友好度 72/100
servo/rust-smallvec#824 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
-
难度 2/5 1-3 小时 新手友好度 76/100
superradcompany/microsandbox#1974 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
维护者通常 1 天内回复
-
priority middle
难度 1/5 1 小时以内 新手友好度 62/100
KATO-Hiro/AtCoderClans#12940 ·
维护者通常 1 天内回复