API Proposal: `HasOnDeleteSetNullProperties()` to support Postgres 15+ `ON DELETE SET NULL (column_a, column_b)` column lists

未关闭
#3,895 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
45/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
csharp, postgresql
领域
backend, databases

调研方向

Start by reading the Npgsql annotation provider and migrations SQL generator, especially their foreign-key constraint handling; the issue’s prototype shows the intended integration points but does not name repository file paths or tests. Check existing tests for foreign-key migration SQL and annotation handling, then add coverage for the proposed property- and column-based APIs. Done means generated migrations include the selected column list for SET NULL or SET DEFAULT.

由索引模型根据 Issue 内容生成。

描述

Preface

PostgreSQL 15+ added support for specifying a list of columns after a ON DELETE SET NULL or ON DELETE SET DEFAULT constraint, which specifies which subset of a composite foreign key's columns to set to NULL when the principal is deleted, instead of all columns in the foreign key.

The DDL constraints documentation states:

The actions SET NULL and SET DEFAULT can take a column list to specify which columns to set. Normally, all columns of the foreign-key constraint are set; setting only a subset is useful in some special cases.

For example:

FOREIGN KEY (tenant_id, author_id) REFERENCES users ON DELETE SET NULL (author_id);

Npgsql does not yet support a built-in way to target specific SET NULL columns using the standard Fluent API.

Proposed API

An extension method for ReferenceCollectionBuilder named HasOnDeleteSetNullColumns() for specifying raw column names, and HasOnDeleteSetNullProperties() for the property names, with overloads for string array and lambda expression:

public static ReferenceCollectionBuilder HasOnDeleteSetNullColumns(
    this ReferenceCollectionBuilder builder,
    params string[] setNullColumnNames)

public static ReferenceCollectionBuilder HasOnDeleteSetNullProperties(
    this ReferenceCollectionBuilder builder,
    params string[] setNullPropertyNames)

public static ReferenceCollectionBuilder<TPrincipalEntity, TDependentEntity> HasOnDeleteSetNullProperties<TPrincipalEntity, TDependentEntity>(
    this ReferenceCollectionBuilder<TPrincipalEntity, TDependentEntity> builder,
    Expression<Func<TDependentEntity, object?>> setNullPropertiesExpression)
        where TPrincipalEntity : class
        where TDependentEntity : class

Example usage

modelBuilder.Entity<Author>()
    .HasMany(a => a.Posts)
    .WithOne(p => p.Author)
    .HasPrincipalKey(a => new { a.TenantId, a.Id })
    .HasForeignKey(p => new { p.TenantId, p.AuthorId })
    .OnDelete(DeleteBehavior.SetNull)
    .HasOnDeleteSetNullProperties(p => p.AuthorId);
    // or .HasOnDeleteSetNullProperties("AuthorId");
    // or .HasOnDeleteSetNullColumns("author_id");

Workarounds

Current workarounds include manually modifying the migrations with custom SQL to drop the initial constraint and re-add it with the column list, or to manually extend the migration generator. The latter being the path I took to prototype an implementation of this proposal, which may serve as the basis for a future PR.

This prototype implements:

  • Two custom annotations:
    • "CustomNpgsql:OnDeleteSetNull:PropertyNames" is the property name list
    • "CustomNpgsql:OnDeleteSetNull:ColumnNames" is the actual column name list
  • ReferenceCollectionBuilder extension methods
    • Adds the annotations to the Foreign Key Constraint
  • Derived NpgsqlAnnotationProvider
    • Translates "CustomNpgsql:OnDeleteSetNull:PropertyNames" into concrete column names and re-adds them into the relational model as "CustomNpgsql:OnDeleteSetNull:ColumnNames"
    • Yields existing "CustomNpgsql:OnDeleteSetNull:ColumnNames" to the relational model
  • Derived MigrationsSqlGenerator
    • Adds on the additional column list SQL during ForeignKeyConstraint generation
Extension methods
public static ReferenceCollectionBuilder HasOnDeleteSetNullColumns(
    this ReferenceCollectionBuilder builder,
    params string[] setNullColumnNames)
    {
        builder.HasAnnotation(
            "CustomNpgsql:OnDeleteSetNull:ColumnNames",
            setNullColumnNames);

        return builder;
    }

public static ReferenceCollectionBuilder HasOnDeleteSetNullProperties(
    this ReferenceCollectionBuilder builder,
    params string[] setNullPropertyNames)
    {
        builder.Metadata.SetAnnotation(
            "CustomNpgsql:OnDeleteSetNull:PropertyNames",
            setNullPropertyNames);

        return builder;
    }

public static ReferenceCollectionBuilder<TPrincipalEntity, TDependentEntity> HasOnDeleteSetNullProperties<TPrincipalEntity, TDependentEntity>(
    this ReferenceCollectionBuilder<TPrincipalEntity, TDependentEntity> builder,
    Expression<Func<TDependentEntity, object?>> setNullPropertiesExpression)
        where TPrincipalEntity : class
        where TDependentEntity : class
    {
        string[] setNullPropertyNames = setNullPropertiesExpression
            .GetMemberAccessList()
            .Select(member => member.Name)
            .ToArray();

        builder.Metadata.SetAnnotation(
            "CustomNpgsql:OnDeleteSetNull:PropertyNames",
            setNullPropertyNames);

        return builder;
    }
Custom NpgsqlAnnotationProvider
public class CustomNpgsqlAnnotationProvider : NpgsqlAnnotationProvider
{
    public CustomNpgsqlAnnotationProvider(RelationalAnnotationProviderDependencies dependencies)
        : base(dependencies)
    {
    }

    public override IEnumerable<IAnnotation> For(IForeignKeyConstraint foreignKeyConstraint, bool designTime)
    {
        foreach(IAnnotation baseAnnotion in base.For(foreignKeyConstraint, designTime)) {
            yield return baseAnnotion;
        }

        foreach (IForeignKey thisForeignKey in foreignKeyConstraint.MappedForeignKeys)
        {
            if (thisForeignKey.FindAnnotation("CustomNpgsql:OnDeleteSetNull:ColumnNames")?.Value is string[] columnNames)
            {
                yield return new Annotation(
                        "CustomNpgsql:OnDeleteSetNull:ColumnNames",
                        columnNames
                    );
            }

            // Translate CustomNpgsql:OnDeleteSetNull:PropertyNames -> CustomNpgsql:OnDeleteSetNull:ColumnNames
            if (thisForeignKey.FindAnnotation("CustomNpgsql:OnDeleteSetNull:PropertyNames")?.Value is string[] propertyNames)
            {
                // Translate property names to column names using the set of columns from the foreign key constraint
                string[] columnNames = propertyNames
                    .SelectMany(p =>
                        foreignKeyConstraint.Columns
                        .Where(c => c.PropertyMappings.Any(pm => pm.Property.Name == p))
                    )
                    .Select(c => c.Name)
                    .ToArray();

                yield return new Annotation(
                        "CustomNpgsql:OnDeleteSetNull:ColumnNames",
                        columnNames
                    );
            }
        }
    }
}
Custom NpgsqlMigrationsSqlGenerator
public class CustomNpgsqlMigrationsSqlGenerator : NpgsqlMigrationsSqlGenerator {
    protected override void ForeignKeyConstraint(AddForeignKeyOperation operation, IModel? model, MigrationCommandListBuilder builder)
    {
        // Write the constraint as standard. This is not yet terminated.
        base.ForeignKeyConstraint(operation, model, builder);

        // Only append column list to SET NULL or SET DEFAULT
        if (operation.OnDelete is ReferentialAction.SetNull or ReferentialAction.SetDefault
            && operation?.FindAnnotation("CustomNpgsql:OnDeleteSetNull:ColumnNames")?.Value is string[] columnNames && columnNames.Length > 0)
        {    
            // Append the column list
            builder.Append(" (");
            builder.Append(ColumnList(columnNames));
            builder.Append(")");
        }
    }
}
主要语言
C#
星标
1.8k
派生
268
平均合并
2 小时 35 分钟
30 天内合并 PR
136

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

npgsql/efcore.pg 的其他 Issue

查看 npgsql/efcore.pg 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。