Using HasData to seed an Entity with a mapped Enum creates a migration that errors with: PostgresException (0x80004005) 42703: column "{{enum value}}"

未关闭
  • 哪里不对？
#3,426 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
csharp, postgresql
领域
databases

调研方向

Start by reproducing the reported case: map the PostgreSQL enum and seed the entity with HasData, then generate and run the initial migration. Inspect the generated InsertData values for the enum. The issue is resolved when the migration runs successfully without treating the enum value as a column name.

由索引模型根据 Issue 内容生成。

描述

Hi,

I think this is a minor bug on migration code generation, and while I found a work around, I thought I'd contribute my findings. I searched issues and didn't see anyone mention this yet.

Consider the below setup where Voice is an Entity model, and it has a reference to an enumeration, VoiceSource

An enumeration with Npgsql mapping added
public enum VoiceSource
{
    Recording = 0,
    Azure = 1,
}

opt.UseNpgsql(
        builder.Configuration.GetConnectionString("ZabaanDbContext"),
        o =>
        {
            o.MapEnum<VoiceSource>(nameof(VoiceSource));
            o.UseNodaTime();
        }
    );
I have some seed data configured:
public static readonly Voice Voices_AzureFarid = new Voice
{
    Id = VoiceId.AzureFarid, // vogen wrapped urn
    Source = VoiceSource.Azure,
    SourceIdentifier = "fa-IR-FaridNeural",
    Name = "Farid",
};

public static readonly Voice Voices_AzureDilara = new Voice
{
    Id = VoiceId.AzureDilara, // vogen wrapped urn
    Source = VoiceSource.Azure,
    SourceIdentifier = "fa-IR-DilaraNeural",
    Name = "Dilara",
};

modelBuilder.Entity<Voice>(voice =>
{
    voice.HasIndex(e => new { e.Source, SourceIdentifer = e.SourceIdentifier }).IsUnique();
    voice.HasIndex(e => e.Name).IsUnique();
    voice.HasData(Voices_AzureFarid, Voices_AzureDilara);
});
Then, when I make my INITIAL database migration, this code is generated where the enumeration is referenced directly:
migrationBuilder.InsertData(
    table: "Voices",
    columns: new[] { "Id", "Name", "Source", "SourceIdentifier" },
    values: new object[,]
    {
        { "urn:zabaan:voice:0a57108b-18d7-4877-ac09-67d73150da08", "Dilara", VoiceSource.Azure, "fa-IR-DilaraNeural" },
        { "urn:zabaan:voice:d0d96aa5-971b-4d78-a606-471469663c34", "Farid", VoiceSource.Azure, "fa-IR-FaridNeural" }
    });
Which fails to run via the migration bundle application:
INSERT INTO "Voices" ("Id", "Name", "Source", "SourceIdentifer")
VALUES ('urn:zabaan:voice:d0d96aa5-971b-4d78-a606-471469663c34', 'Farid', Azure, 'fa-IR-FaridNeural');
Npgsql.PostgresException (0x80004005): 42703: column "azure" does not exist
The fix

Updating the migration file manually to use the string value wrapped with single quotes fixed the issue and the migration succeeds:

migrationBuilder.InsertData(
    table: "Voices",
    columns: new[] { "Id", "Name", "Source", "SourceIdentifier" },
    values: new object[,]
    {
        { "urn:zabaan:voice:0a57108b-18d7-4877-ac09-67d73150da08", "Dilara", "\'azure\'", "fa-IR-DilaraNeural" },
        { "urn:zabaan:voice:d0d96aa5-971b-4d78-a606-471469663c34", "Farid", "\'azure\'" , "fa-IR-FaridNeural" }
    });

The single quotes wrapping the "azure" are necessary FYI, I first tried it without and that also failed.

Failed executing DbCommand (56ms) [Parameters=[], CommandType='Text', CommandTimeout='30']
INSERT INTO "Voices" ("Id", "Name", "Source", "SourceIdentifer")
VALUES ('urn:zabaan:voice:0a57108b-18d7-4877-ac09-67d73150da04', 'Dilara', azure, 'fa-IR-DilaraNeural');
INSERT INTO "Voices" ("Id", "Name", "Source", "SourceIdentifer")
VALUES ('urn:zabaan:voice:d0d96aa5-971b-4d78-a606-471469663c38', 'Farid', azure, 'fa-IR-FaridNeural');
Npgsql.PostgresException (0x80004005): 42703: column "azure" does not exist
主要语言
C#
星标
1.8k
派生
268
平均合并
2 小时 35 分钟
30 天内合并 PR
136

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

npgsql/efcore.pg 的其他 Issue

查看 npgsql/efcore.pg 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。