make error when run without access to `/proc`

未关闭

#3,059 创建于 2024年8月15日 0 条评论 0 个 reaction 已指派 0 人在 GitHub 查看

还没有人认领这个 Issue。

评估

难度: 2/5
预计耗时: 1-3 小时
新手友好度: 55/100

Issue 类型: 缺陷
描述清晰度: 描述清楚
活跃度: 停滞
技术栈: javascript, linux, node.js
领域: build-system, tooling

调研方向

从 lib/build.js 的第 176-179 行开始，使用提供的带有 ProcSubset=pid 的 systemd-run 命令复现 zero-CPU 结果。检查生成的 make 参数，并验证当 os.cpus() 返回空数组时，构建不再传递作业数 0。

由索引模型根据 Issue 内容生成。

描述

Node Version: node = v20.16.0, npm = 10.8.1
Platform: Linux 6.8.0-40-generic x86_64
Module: re2

Verbose output (from npm or node-gyp):

npm error gyp info spawn args [ 'BUILDTYPE=Release', '-C', 'build', '--jobs', 0 ]
npm error make: the '-j' option requires a positive integer argument

When building a package using the systemd security option ProcSubset=pid, gyp sets the number of jobs to 0, which make does not accept.

I believe the relevant code is here: https://github.com/nodejs/node-gyp/blob/e6f4ede10cca28e9edeaa85d7830914c5d1499c7/lib/build.js#L176-L179

The documentation for Node function os.cpus() says:

Returns an array of objects containing information about each logical CPU core. The array will be empty if no CPU information is available, such as if the /proc file system is unavailable.

This can be shown by getting the number of CPUs in a transient service unit:

$ node -e "console.log(require('node:os').cpus().length)"
16

$ sudo systemd-run -p ProcSubset=pid -t -- \
  node -e "console.log(require('node:os').cpus().length)"
0

In the event of os.cpus() not returning any information, I suggest that gyp should either default to some constant number of parallel jobs or let make run as many jobs as it wants.

主要语言: Python
星标: 10.7k
派生: 1.9k
平均合并: 1 天 4 小时
30 天内合并 PR: 5