Automatic detection of "Fixes" should be stricter

未关闭

#592 创建于 2021年11月11日 1 条评论 0 个 reaction 已指派 0 人在 GitHub 查看

还没有人认领这个 Issue。

评估

难度: 3/5
预计耗时: 1-2 天
新手友好度: 42/100

Issue 类型: 缺陷
描述清晰度: 基本清楚
活跃度: 停滞
技术栈: javascript, node.js
领域: tooling

调研方向

使用 PR #40613 和此 issue 中显示的生成元数据作为复现案例；跟踪从提交消息中检测 Fixes 元数据的 node-core-utils 入口点。完成的标准是，提及“fix”的文字不再生成不正确的 Fixes 行，同时仍能检测到有效的 Fixes 引用。

由索引模型根据 Issue 内容生成。

描述

bug

In https://github.com/nodejs/node/pull/40613, node-core-utils@1.30.0 incorrectly adds a Fixes: metadata line:

----------------------------------- PR info ------------------------------------
Title      crypto: fix build without scrypt (#40613)
Author     Martin 'JaMa' Jansa <Martin.Jansa@gmail.com> (@shr-project, first-time contributor)
Branch     shr-project:jansa/scrypt -> nodejs:master
Labels     crypto, c++, author ready
Commits    1
 - crypto: fix build without scrypt
Committers 1
 - Martin Jansa <martin.jansa@lge.com>
PR-URL: https://github.com/nodejs/node/pull/40613
Fixes: https://github.com/In
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40613
Fixes: https://github.com/In
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------

The commit message was:

crypto: fix build without scrypt

* add missing semicolon to fix:
  In file included from ../src/node_crypto.h:47,
                   from ../src/node.cc:46:
  ../src/crypto/crypto_scrypt.h:80:2:
  error: expected ';' after struct definition
     80 | }
        |  ^
        |  ;

  and fix typo in the comment

Signed-off-by: Martin Jansa <martin.jansa@lge.com>

_{(Original post in https://github.com/nodejs/node/pull/40613#issuecomment-966507251.)}