core: output order changes between builds
维护者通常 3 天内回复
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 76/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript, node.js
- 领域
- build-system, tooling
调研方向
Start with packages/core/src/threading/parallel.mjs and the existing test in packages/core/src/threading/__tests__/parallel.test.mjs; use the fake pool described in the issue to confirm output order. Then inspect the globSync calls in packages/core/src/generators/ast/generate.mjs and ast-js/generate.mjs, checking the status of PRs #1180 and #1179 first. Add focused tests and verify repeated builds produce stable output order.
由索引模型根据 Issue 内容生成。
描述
Building the same docs twice can give different files, because the order of the output depends on which worker finishes first. Two things combine:
createParallelWorker().stream()sends every chunk to the worker pool at once, then yields the results withPromise.race, so in whatever order the workers happen to finish.- The
astandast-jsgenerators list input files withtinyglobby'sglobSync, which doesn't sort, so even the order chunks are sent in can change between machines.
Generators that don't sort for themselves pass that order on. These files can change between identical builds:
sitemap.xml(<url>order)llms.txtandllms-full.txt(link and page order)orama-db.json(document order; its ids are a separate issue)- the legacy
all.html(table of contents, sidebar and content) api-docs.jsonfromjson-simpleapilinks.json(key order)
That makes diffs noisy, wastes caching, and keeps CI from comparing outputs byte for byte (today it can only compare file sizes). Generators that already sort need no change: legacy-json-all, json-all, the React all.html, jsx-ast and legacy-html.
Where to look
packages/core/src/threading/parallel.mjs:99-137: every chunk is submitted at once, then thewhile (pending.size)loop yields withawait Promise.race(pending)(line 126).packages/core/src/caching.mjs:21-24:collectAsyncGeneratorkeeps chunks in the order they arrive.packages/core/src/generators/ast/generate.mjs:117-124andast-js/generate.mjs:47-49: unsortedglobSyncresults.packages/node-legacy/src/legacy-json-all/generate.mjs:39-52: an example of a consumer that already sorts.
How to reproduce
You don't need real workers. With a fake pool where later chunks finish first:
import createParallelWorker from './packages/core/src/threading/parallel.mjs';
const pool = {
run: async task => {
await new Promise(resolve => setTimeout(resolve, 50 - task.input[0] * 10));
return task.input;
},
};
const worker = createParallelWorker('x', { name: 'x' }, pool, {
threads: 2,
chunkSize: 1,
});
const out = [];
for await (const chunk of worker.stream([0, 1, 2, 3, 4], {})) out.push(...chunk);
console.log(out); // [ 4, 3, 2, 1, 0 ], expected [ 0, 1, 2, 3, 4 ]
(Run it from the repo root as an .mjs file. If the logger import gets in the way, the test file below is the easier place to try it.)
Suggested approach
-
Yield in submission order. All chunks still start at once, so it isn't any slower; the loop just awaits them in order:
const promises = chunks.map(indices => pool.run(createTask(/* ... */))); for (const [index, promise] of promises.entries()) { const result = await promise; // keep the "Chunk N/M completed" debug log yield result; }The
{ promise, result }wrapper and thependingSet can go, and the JSDoc should say "in submission order". -
Sort the glob results with a plain
.sort(), notlocaleCompare, so the order doesn't depend on the machine's locale. Inast/generate.mjs, sort each pattern's results before mapping them to[child, parent], which keeps the order ofconfig.input.
Two open PRs touch the same code, so check where they stand when you start:
- #1180 replaces
tinyglobbywithfindFilesinpackages/core/src/utils/glob.mjs. If it has landed, sort there instead, once, for every caller. - #1179 already makes the single-thread path run chunks one after another, in order. If it has landed, only the worker pool path needs the change.
How to test
In packages/core/src/threading/__tests__/parallel.test.mjs, add a case with a fake pool like the one above (no real workers needed) and assert that [0, 1, 2, 3, 4] comes back in order. For the glob sort, packages/core/src/generators/ast/__tests__/generate.test.mjs already creates a temp folder: write a few files in a jumbled order and assert the generated paths come back sorted. Run everything with node --run test.
Things to watch out for
- Fix the order once, at the source. Don't add sorting to each consumer (
sitemap,llms-txt, ...). - In
ast/generate.mjs, sort before the.mapinto[child, parent]tuples, because.sort()on arrays would compare them as strings. - After this, the legacy
all.htmlfollowslegacy-html's order (modules sorted by name). Whether it should followconfig.indexlikelegacy-json-allis a separate question. orama-db.jsonalso needs stable document ids to be reproducible: #1184.
Getting started
New to doc-kit? CONTRIBUTING.md covers setup, running the tests and adding a changeset (node --run changeset, a patch for @doc-kit/core). Leave a comment here if you'd like to take it on.
- 主要语言
- JavaScript
- 星标
- 70
- 派生
- 79
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 53
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nodejs/doc-kit 的其他 Issue
-
addon-verify: re-indents the test.js it generates可能已有人在做 @Mittalnew 今天认领。 未关闭good first issue help wanted
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 3 天内回复
-
难度 2/5 半天 新手友好度 68/100
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 3 天内回复
-
good first issue help wanted Web Generator
难度 3/5 1-2 天 新手友好度 65/100
维护者通常 3 天内回复
-
sitemap: lists the index page twice when index.md is an input可能已有人在做 @helmipradita 今天认领。 未关闭good first issue help wanted Web Generator
难度 2/5 1-3 小时 新手友好度 1/100
维护者通常 3 天内回复
相似的 Issue
-
ai-driven-fuzzing bug claude Minor
难度 2/5 1-3 小时 新手友好度 78/100
linagora/cozy-client#1777 · 1 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
[guide] AGENTS.md claims the coverage gate, e2e and full lint run on every PR after ADR 0011 focused validation可能已有人在做 @hivecommons-hive 今天认领。 未关闭agent/guide documentation hive/claimed-by-guide stage/040-covered-by-pr
难度 2/5 1-3 小时 新手友好度 81/100
维护者通常 1 天内回复
-
check:passed feeds:add
难度 2/5 1-3 小时 新手友好度 65/100
维护者通常 4 天内回复
-
CMS video element: "CmsVideoPlugin" sets `volume = 0`, so videos cannot be unmuted on Android Chrome未关闭needs-triage Platform(Default)
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
all-contributors/cli#587 ·
维护者通常 1 天内回复