Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Working out a policy around reverts for LTS branches

未关闭
#535 0 条评论 4 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
文档
描述清晰度
需要澄清
活跃度
停滞
技术栈
node.js
领域
release

调研方向

首先审查针对 LTS、Current 和 master 分支上回归问题的拟议处理方式,包括 revert 和 cherry-pick 的行为。当 Release Working Group 同意一项说明 revert 应落在哪些位置以及如何跟踪临时回归的策略时,即视为完成。

由索引模型根据 Issue 内容生成。

描述

With the v12.16.0 release, a number of regressions has been introduced, some (most?) of which also applied to v13.x and master.

One approach that has been taken to address this is to revert the problematic commits on v12.x-staging only.

I would like to handle this situation differently in the future, and work out a policy around that. I think the most important downside to the aforementioned approach is that the reverts only land on v12.x-staging, bringing LTS out of sync with the rest of our branches, while fixes are being worked on in master:

  • It makes working on fixes harder from a purely technical perspective. Once they land on master, they would typically have to be backported to LTS manually, together with a revert of the revert(s) that were applied to LTS only.
  • It makes it harder to have an overview of which regressions exist on which release lines. While we do apply labels to PRs to keep track of their backporting state, it doesn’t let us know which bugs have been temporarily solved through reverts that should be taken care of sooner rather than later. This is especially bad when the original change that was reverted was a bug fix; there is no way of tracking that a bug has been intentionally re-introduced as a “temporary” measure on LTS only.
  • It does not motivate working on fixes. If a change is reverted on master, I generally believe that the authors are more inclined to work on a fixed version of their changes compared to when the changes are “just” excluded from LTS.
  • It presents stability of master and Current releases as less important. Yes, it should be the priority to keep LTS as stable as possible, but I think we should do our best to avoid bugs in Current as well.

My suggestion for handling these types of situations would be:

  • For bugs that only occur in LTS, a revert PR against the staging branch is opened and applied. I don’t think we need any special fast-tracking rules, as we’ve been handling the staging branches that way anyway. I do think that an explicit revert PR is good for documentation purposes, even if it’s landed immediately after opening.
  • For bugs that occur on master, a revert PR is opened against master, and then cherry-picked back to the release lines where it applies. If pushing out releases in a timely manner is a concern here that isn’t covered by our regular fast-tracking rules, then I’m open to making changes to our policy for that.

/cc @MylesBorins

主要语言
JavaScript
星标
4.4k
派生
675
平均合并
22 小时 29 分钟
30 天内合并 PR
1

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

nodejs/Release 的其他 Issue

查看 nodejs/Release 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。