[Bug]: "inf" value in bootstrap of mean size-at-age data for ages with sample size 0
@Rick-Methot-NOAA 已经在做这个了。
开始于 2024年5月2日。
评估
这个 Issue 还没有评估数据。
描述
Describe the bug
@e-perl-NOAA reported "inf" values in the bootstraps of the mean size-at-age data for the BigSkate_2019 test model.
I was able to replicate the issue in the attached files.
There is a single vector of observations where the last three bins (for males age 13-15) have 0 sample size. The bootstrap observations are reported as inf 0.0001 inf in data_boot_001.ss and as 0.0001 inf inf in data_boot_002.ss in the attached files:
boot.zip.
It looks like the code here may be randomly generating a mix of inf and -inf and then replacing the -inf with 0.0001.
https://github.com/nmfs-ost/ss3-source-code/blob/main/SS_write_ssnew.tpl#L1271-L1275
I think the following steps should be taken:
- decide on a placeholder value for the observation. SS3 doesn't like
NA(orinf) as an input value here. I used 99.9 in the original Big Skate model, perhaps because it was closer to the range of observed non-placeholder values whereas 999 would have messed up scaling in any rudimentary plot of the results before filtering those observations). - add a test for
obs_ms_n(f, i, a) == 0and use the placeholder value instead of generating a bootstrap value
Note that these data are excluded from the likelihood with a lambda = 0 setting, but I think that doesn't matter for any of this.
To Reproduce
Run the attached input files (which is just the BigSkate_2019 in ss3-test-models with the starter file changed to produce bootstrap files).
Expected behavior
A model without inf output that can be used as an SS3 input file.
Screenshots
No response
Which OS are you seeing the problem on?
No response
Which version of SS3 are you seeing the problem on?
No response
Additional Context
No response
- 主要语言
- C++
- 星标
- 46
- 派生
- 20
- 平均合并
- 2 天 6 小时
- 30 天内合并 PR
- 1
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
nmfs-ost/ss3-source-code 的其他 Issue
-
[Bug]: non-integer `Lbin_lo`/`Lbin_hi` are silently truncated under `Lbin_method = 1`, while method 3 raises a fatal error for the equivalent mistake可能已有人在做 @Rick-Methot-NOAA 于 15 天前认领。 未关闭
nmfs-ost/ss3-source-code#784 · 已指派 1 人 ·
-
need warning and improved logic for generalized sizecomp可能重新可做 @Rick-Methot-NOAA 于 250 天前认领，目前没有进行中的 PR。 未关闭composition in progress
nmfs-ost/ss3-source-code#751 · 1 条评论 · 已指派 1 人 ·
-
[Feature]: Add standard errors for area-specific quantities可能重新可做 @Rick-Methot-NOAA 于 388 天前认领，目前没有进行中的 PR。 未关闭area & movement
nmfs-ost/ss3-source-code#731 · 3 条评论 · 已指派 1 人 ·
-
[Feature]: Create a basic report list that could serve as better starting configuration for customization可能重新可做 @Rick-Methot-NOAA 于 395 天前认领，目前没有进行中的 PR。 未关闭misc. output
nmfs-ost/ss3-source-code#723 · 已指派 1 人 ·
-
[Feature]: restrict biology output using the use_morph(g) flag可能重新可做 @Rick-Methot-NOAA 于 417 天前认领，目前没有进行中的 PR。 未关闭biology misc. output ongoing
nmfs-ost/ss3-source-code#702 · 已指派 1 人 ·
查看 nmfs-ost/ss3-source-code 的全部 Issue
相似的 Issue
-
upstream update
难度 2/5 1-3 小时 新手友好度 65/100
conan-io/conan-center-index#31142 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 84/100
NVIDIA/DeepStream#78 ·