[Feature]: Add capability for seasonal offset in a CPUE catchability
@Rick-Methot-NOAA 已经在做这个了。
开始于 2023年7月21日。
评估
这个 Issue 还没有评估数据。
描述
Describe the solution you would like.
I often see model configurations in which users create season-specific fleets in order to have season-specific Q, and sometimes season-specific selectivity. Most often, it is to get at season-specific Q. Addition of a capability to have season-specific Q would provide a more convenient and probably faster-executing option.
- review how seasonality in MGparms is implemented to see if extendable to Q
- consider generic capability to have seasonality in any parameter, especially selectivity parameters
Describe alternatives you have considered
The MGparm approach has specific input for each parameter type. If selected, then season parameters created to do:
if (MGparm_seas_effects(j) > 0)
{
wtlen_seas(0, gp, j) = 0.0;
for (s = 1; s <= nseas; s++)
{
wtlen_seas(s, gp, j) = mfexp(MGparm(MGparm_seas_effects(j) + s));
A feasible generic implementation could be:
if abs(Block_type_rd) > 10, then block_type = sign(block_type_rd) * (abs(Block_type_rd) - 10).
then value in tens place would be the control for seasonality. This allows seasonality to be in addition to blocks and trends on base parameter.
The use of abs and sign is because a negative block is the indicator for trend approach.
- count number of Q parameters that request seasonality
- for each of them, create a Q_seas(f,s) parameter.
- check to be sure float is off and check to see that one of the seasons has fixed Q_seas = 0.0 to be the base.
- implement the Q_seas in exp_val where Q as parameter code already is located
https://vscode.dev/github/nmfs-stock-synthesis/stock-synthesis/blob/main/SS_expval.tpl#L398-L399 - Nice to have: check data to see which seasons have obs, then create parameter only for those seasons.
Statistical validity, if applicable
NA
Describe if this is needed for a management application
NA
Additional context
No response
- 主要语言
- C++
- 星标
- 46
- 派生
- 20
- 平均合并
- 2 天 6 小时
- 30 天内合并 PR
- 1
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
nmfs-ost/ss3-source-code 的其他 Issue
-
[Bug]: non-integer `Lbin_lo`/`Lbin_hi` are silently truncated under `Lbin_method = 1`, while method 3 raises a fatal error for the equivalent mistake可能已有人在做 @Rick-Methot-NOAA 于 15 天前认领。 未关闭
nmfs-ost/ss3-source-code#784 · 已指派 1 人 ·
-
need warning and improved logic for generalized sizecomp可能重新可做 @Rick-Methot-NOAA 于 250 天前认领，目前没有进行中的 PR。 未关闭composition in progress
nmfs-ost/ss3-source-code#751 · 1 条评论 · 已指派 1 人 ·
-
[Feature]: Add standard errors for area-specific quantities可能重新可做 @Rick-Methot-NOAA 于 389 天前认领，目前没有进行中的 PR。 未关闭area & movement
nmfs-ost/ss3-source-code#731 · 3 条评论 · 已指派 1 人 ·
-
[Feature]: Create a basic report list that could serve as better starting configuration for customization可能重新可做 @Rick-Methot-NOAA 于 395 天前认领，目前没有进行中的 PR。 未关闭misc. output
nmfs-ost/ss3-source-code#723 · 已指派 1 人 ·
-
[Feature]: restrict biology output using the use_morph(g) flag可能重新可做 @Rick-Methot-NOAA 于 417 天前认领，目前没有进行中的 PR。 未关闭biology misc. output ongoing
nmfs-ost/ss3-source-code#702 · 已指派 1 人 ·
查看 nmfs-ost/ss3-source-code 的全部 Issue
相似的 Issue
-
upstream update
难度 2/5 1-3 小时 新手友好度 65/100
conan-io/conan-center-index#31142 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 84/100
NVIDIA/DeepStream#78 ·