Linked spreadsheet: Never overwrite existing data
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- javascript
- 领域
- backend
调研方向
首先查看 PR #1758,并追踪它引入的电子表格写入路径。确认新响应如何选择行,以及电子表格更新如何持久化,然后定义用于保留现有内容并防止并发提交丢失条目的覆盖范围。完成的标准是新响应会追加内容,而不会覆盖之前的行或编辑。
由索引模型根据 Issue 内容生成。
描述
I previously posted this as feedback on the PR before it was applied (https://github.com/nextcloud/forms/pull/1758#issuecomment-1896763727), but since it was out of scope for the initial PR, I'm reposting this here.
Nextcloud:
- Nextcloud-Version: 28.0.1
- Forms-Version: 4.0.0 with PR #1758 applied
Is your feature request related to a problem? Please describe.
Usecase
The usecase I want to implement is a logbook for work on the electrical installation in a building. We currently have a spreadsheet in Nextcloud with a line for each change made, with some details about what, where, who, when, etc. To lower the bar for people to enter something in the logbook (and importantly, to allow unauthenticated users to add but not edit entries), I want to use a public form that adds entries to this logbook (and then put up QR-codes in the electrical cabinets so people can find the form).
Overwriting data
Currently every time a new answer is added, the field names and all previous answers are also written to the spreadsheet (again). This means that I cannot:
- Manually add a row in the spreadsheet - it will be overwritten by the next form response
- Edit any form data in the spreadsheet (fix typo's, add extra info) - it will be reverted on the next form response
- Add extra rows above the table with some instructions for users of the spreadsheet
- Insert extra columns in between the result columns or reorder columns (adding extra columns to the right of the results works already).
The first three are problematic for my usecase - the reason I want to export to a spreadsheet is so I have the logbook in an easy to manage and edit form, and also so people that are more familiar with the tech can just add their entries directly in the spreadsheet. Problem 4 I added for completeness, fixing it would be nice but also easy to work around by adding extra data to the right if needed.
Describe the solution you'd like
Just add only values for the new entry on the first empty row in the spreadsheet, never modify any existing content. This also means that the header row with column names should be written only when the sheet is completely empty. This should fix problem 1-3 above, but leave problem 4 unfixed.
As a side effect, this does mean that if the form is modified to e.g. add extra questions, the column headers become outdated (and also old and new answers might put the same answer in different columns). Also, it leaves problem 4 unfixed. This could maybe be fixed by doing a column lookup first: When writing a new answer, look in the first row for the corresponding column name and write the answer into that column. If the column name is not found in the first row, write the column name to the first empty cell in the first row, and then write the answer in the same column. This would fix problem 4, but unfix problem 3 (since the column headers must now remain in the first row), unless we can somehow tell the forms app in what row the column headers live (using a configurable row offset, or maybe some magic tag value in the spreadsheet, not sure if that can be done invisibly to the user)?
Personally, I suspect that the extra complexity of fixing problem 4 is not worth the trouble, so it should be fine to fix just 1-3 and leave 4 unfixed. The most important part is that then existing data is never overwritten, so any weirdness in column layout will be visible to the user and they can just fix up things manually or adjust their workflow.
Challenges
One potential challenge with my proposed solution is that atomicity of writing data to the spreadsheet becomes more relevant. If each for submission only writes one entry, and two submissions happen at the same time, there might be (depending on implementation - I have not checked) a risk of one submission overwriting the previous one, dropping one entry. With the current code, where all entries are written, this risk is minimal (even if the first submission overwrites the data of the second submission, then a later third submission will write the second response again). This should probably be solved with some kind of locking to make sure that no changes are made to the spreadsheet between loading it from storage and writing the updated file.
- 主要语言
- JavaScript
- 星标
- 384
- 派生
- 130
- 平均合并
- 19 小时 35 分钟
- 30 天内合并 PR
- 56
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nextcloud/forms 的其他 Issue
-
0. Needs triage enhancement
难度 4/5 3-5 天 新手友好度 48/100
维护者通常 1 天内回复
-
0. Needs triage enhancement needs info
难度 4/5 3-5 天 新手友好度 45/100
nextcloud/forms#3733 · 1 条评论 ·
维护者通常 1 天内回复
-
0. Needs triage enhancement needs info
难度 4/5 3-5 天 新手友好度 48/100
nextcloud/forms#3732 · 1 条评论 ·
维护者通常 1 天内回复
-
0. Needs triage enhancement
难度 3/5 1-2 天 新手友好度 67/100
nextcloud/forms#3683 · 1 条评论 ·
维护者通常 1 天内回复
-
Replace description fields with NcRichText可能重新可做 @vishruthasgowda 于 64 天前认领,目前没有进行中的 PR。 未关闭1. to develop enhancement feature: 📑 form creation good first issue javascript
nextcloud/forms#3587 · 3 条评论 · 1 个 reaction · 已指派 1 人 ·
维护者通常 1 天内回复
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 1 天内回复
-
status: waiting for maintainer
难度 2/5 1-3 小时 新手友好度 66/100
mui/material-ui#49511 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
mpetazzoni/sse.js#122 ·
-
[eslint-plugin] valid-styles rejects <progress> pseudo-elements (::-webkit-progress-bar, ::-webkit-progress-value, ::-moz-progress-bar)可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 2 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
swc-project/swc-next#1022 ·
维护者通常 1 天内回复