use getenv in configs
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- docker, shell
- 领域
- devops, infrastructure
调研方向
首先定位 Docker 镜像配置,以及将值写入 config.php 的现有环境变量初始化逻辑。确定哪些持续运行设置仍是硬编码的,并评估 getenv 是否能够安全地提供这些设置,包括容器密钥和轮换场景。完成标准是:相关设置一致地读取环境变量,同时不移除对手动配置 config.php 的支持。
由索引模型根据 Issue 内容生成。
描述
How to use GitHub
- Please use the 👍 reaction to show that you are interested into the same feature.
- Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
- Subscribe to receive notifications on status change and new comments.
Is your feature request related to a problem? Please describe.
Simply put, I can understand using the environment variables for initialising NC, but then not using environment variables for continued operations seems silly to me. Why hardcode the values when they are initially read from environment variables anyway?
Additionally using environment variables instead of hardcoding would allow using container secrets directly.
Additionally rotating DB passwords or locations becomes a breeze since it would all be done through environment variables.
Describe the solution you'd like
Star using: 'var' => getenv('ENV_VAR') as much as possible since manually editing config.php can be done eitherway.
Describe alternatives you've considered
Doing it myself, while yes I've done this. I see that this would be likely to benefit other people as well.
Additional context
Since this is an "advanced" image when compared to AIO I can understand potential hesitancy to adopt my suggestions. Yet I believe that it will help since it doesn't detract from original deployment methods in any way.
- 主要语言
- Shell
- 星标
- 7.4k
- 派生
- 1.9k
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nextcloud/docker 的其他 Issue
-
1. To develop bug feature: cron image
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 2/5 1-3 小时 新手友好度 70/100
-
bug docs
难度 1/5 1 小时以内 新手友好度 72/100
-
0. Needs triage bug
难度 4/5 3-5 天 新手友好度 35/100
-
Imagick architecture mismatch (x86_64 vs aarch64) on official arm64 image causes Apache segfaults未关闭0. Needs triage bug
难度 4/5 3-5 天 新手友好度 50/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 62/100
components-web-app/docs#228 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
int-brain-lab/iblscripts#127 · 1 条评论 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
ValveSoftware/SteamOS#2927 ·
-
bug
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
msys2/MSYS2-packages#6813 ·
维护者通常 1 天内回复