PDF viewer: a single tap while reading exits the document to a full-screen single-page view
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 72/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 领域
- mobile-dev
调研方向
首先从 adapter 的整页 OnClickListener 开始,跟踪 PreviewPdfAdapter.kt、PreviewPdfFragment.kt 和 PreviewPdfViewModel.kt 中的点击流程。使用复现步骤比较更改前后的手势行为和导航。完成的标准是:阅读时单次点击不会意外打开独立的全屏页面视图,并且阅读位置得以保留。
由索引模型根据 Issue 内容生成。
描述
⚠️ Before posting ⚠️
- This is a bug, not a question or an enhancement.
- I've searched for similar issues and didn't find a duplicate.
- I've written a clear and descriptive title for this issue.
- I agree to follow Nextcloud's Code of Conduct.
Steps to reproduce
- Open a multi-page PDF from the Files list (native in-app viewer, not "open with" / browser).
- Scroll down a few pages.
- While reading, tap once anywhere on the page (no drag).
- The app opens a separate full-screen view showing only that single page.
- Press back → you return to the document but the reading/scroll position is lost (back near the top).
Expected behaviour
A single tap on the page while reading should not leave the scrollable document, and the reading position must be preserved. Accidental taps are very frequent when reading a long PDF one-handed.
Actual behaviour
PreviewPdfAdapter registers an OnClickListener on the whole page view. Any click on a page calls PreviewPdfViewModel.onClickPage(), which writes the page bitmap to a temp file and launches PreviewBitmapActivity — a separate full-screen activity showing only the tapped page, outside the scrollable RecyclerView. Coming back from it drops the reading position.
Source (current master)
app/src/main/java/com/owncloud/android/ui/preview/pdf/PreviewPdfAdapter.ktL33-35 —binding.root.setOnClickListener { onClickListener(bitmap) }: whole-page click target, no gesture discrimination.app/src/main/java/com/owncloud/android/ui/preview/pdf/PreviewPdfFragment.ktL79-92 — click →viewModel.onClickPage(page)→ observer onpreviewImagePathstartsPreviewBitmapActivity.app/src/main/java/com/owncloud/android/ui/preview/pdf/PreviewPdfViewModel.ktL55-61 —onClickPage()saves the bitmap to cache and sets_previewImagePath.
Android version
16
Device brand and model
Xiaomi Poco X7 Pro 5G
Stock or custom OS?
Stock (Xiaomi HyperOS)
Nextcloud android app version
34.1.1
Nextcloud server version
34.0.3
Using a reverse proxy?
Yes (Traefik) — not relevant, PDF rendering is fully client-side.
Additional information
The full-screen single-page view appears intended as a "tap to zoom" feature, but bound to a plain click on the entire page it fires on every accidental tap during reading. Possible directions: require a double-tap for the zoom view, shrink the tap target, or at least preserve/restore the RecyclerView scroll position when returning from PreviewBitmapActivity.
- 主要语言
- Kotlin
- 星标
- 5.7k
- 派生
- 2.1k
- 平均合并
- 1 天 22 小时
- 30 天内合并 PR
- 135
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
nextcloud/android 的其他 Issue
-
0. Needs triage bug
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 86/100
nextcloud/android#17845 · 2 条评论 ·
维护者通常 1 天内回复
-
[Bug] Lock owned by another client (e.g. Text app) cannot be unlocked from the app可能已有人在做 @falkloewert 于 28 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
nextcloud/android#17837 · 2 个 reaction ·
维护者通常 1 天内回复
-
0. Needs triage
难度 2/5 1-3 小时 新手友好度 84/100
nextcloud/android#17533 · 1 条评论 ·
维护者通常 1 天内回复
-
RC 34.1.0-01: Duplicated wording in creation menu — "New" prefix + creator name produces "New New document" ("Neu Neues Dokument")可能已有人在做 @ChristianTannheimer 于 118 天前认领。 未关闭0. Needs triage bug
难度 2/5 1-3 小时 新手友好度 85/100
维护者通常 1 天内回复
查看 nextcloud/android 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
Kotlin/kotlin-lsp#309 ·
-
area:data-quality importer size:S
难度 2/5 1-3 小时 新手友好度 72/100
enorm-labs/event-junkie#5136 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复
-
Type: Possible bug
难度 2/5 1-3 小时 新手友好度 68/100
spacecowboy/Feeder#1318 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
wangzan101/Mika#644 ·
维护者通常 1 天内回复