admin2: Implement type verification for changing resource settings
还没有人认领这个 Issue。
评估
调研方向
Start by locating admin2’s resource settings update flow and the default resources’ meta.xml entries that define the accept attribute; the issue names no file or test. Check how set() handles values and compare the existing type declarations across resources. Done means settings are validated against consistent supported types and the default resources declare their expected types; the issue also suggests checking whether admin1 has the same problem.
由索引模型根据 Issue 内容生成。
描述
Is your feature request related to a problem? Please describe.
Recently I've gotten myself in a frustrating situation when I attempted to change a setting of the freeroam resource via admin2. Parts of freeroam stopped working as it expected a table in that setting and even using correct JSON formatting admin2 set the setting as a string. A user shouldn't be able to break parts of default resources like this, especially with no easy way to undo the damage in clear sight. The way set() behaves makes it to neither restarting the resource or changing the setting in the resources meta.xml will actually help you get back to normal.
Describe the solution you'd like
Settings already often have a 'accepted' attribute, however it's not even used consistently within default resources. My desired solution would implement some sort of type checking and update all existing default resources to properly define what type of value they expect.
Describe alternatives you've considered
For the more savvy users converting properly JSON formatted values before applying the setting would be enough, however I believe we can do better.
A 'restore default' button would also be the very least we can offer.
Additional context
The main problem is that there is no standardized nomenclature for the 'accept' attribute. Some use 'bool', others 'boolean', then there are some that list possible values like 'true,false', some will say 'float' or 'int' while others say 'positive number'. It's gonna be impossible to suit every single use perfectly. At the very least the default lua types 'boolean' 'number' 'string' and 'table' should be supported, but I believe there is room to catch some of the commonly used nomenclature variants like 'true/false' and add some basic functionality to be able to verify if a value is a 'positive number', within the range of '0-100' or whether a string is shorter than 32 characters.
[Pending testing] I believe admin1 currently has the same issue.
- 主要语言
- Lua
- 星标
- 185
- 派生
- 180
- 平均合并
- 5 天 13 小时
- 30 天内合并 PR
- 2
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
multitheftauto/mtasa-resources 的其他 Issue
-
enhancement
难度 5/5 一周以上 新手友好度 25/100
multitheftauto/mtasa-resources#697 · 7 条评论 · 7 个 reaction ·
-
editor: LOD_MAP table is missing some LOD models可能重新可做 关联的 PR 已关闭且未合并。 未关闭enhancement
难度 3/5 1-2 天 新手友好度 36/100
-
enhancement resource:editor
难度 5/5 一周以上 新手友好度 20/100
multitheftauto/mtasa-resources#388 · 3 个 reaction ·
-
help wanted waiting for feedback
难度 5/5 一周以上 新手友好度 12/100
multitheftauto/mtasa-resources#361 · 8 条评论 · 8 个 reaction ·
-
enhancement resource:editor
难度 5/5 一周以上 新手友好度 25/100
multitheftauto/mtasa-resources#262 · 1 个 reaction ·
查看 multitheftauto/mtasa-resources 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 79/100
google/executor.nvim#46 ·
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
teradata-labs/loom#624 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复