Post-deploy housekeeping: build script order, source maps, ogimage.xcf, old static/ tree

未关闭
  • 哪里不对？
#488 0 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 8 天内回复

@stephaniehobson 已经在做这个了。

开始于 2026年11月9日。

评估

这个 Issue 还没有评估数据。

描述

Small things noticed while building the deploy pipeline (#480). None is urgent; each is independent, so split this up if that is easier.

  • npm run build orders build:app before build:css. build is npm-run-all build:*, which runs alphabetically, so the Vite build runs before the Stylus compile it depends on. It only works today because both CI and the deploy workflow run npm run build:css as a separate step first. Make build self-sufficient (for example build:1-css, build:2-app, build:3-version.json, or an explicit run-s), then drop the separate step from ci.yml and deploy.yml.
  • Source maps ship to the public bucket. vite.config.mjs sets build.sourcemap: true so npm run size can inspect the bundle, which means roughly 3 MB of .map files are uploaded on every deploy. Decide whether that is wanted. If not, generate maps only for the size command (for example via an env var) and leave the production build without them.
  • public/img/ogimage.xcf is deployed. It is a GIMP source file and gets copied into build/ and uploaded with everything else. Move it out of public/ (or into docs/) so only the rendered PNG ships.
  • Old create-react-app static/ tree in the prod bucket. The May 2025 hand upload left static/js/* and friends in gs://moz-fx-data-static-websit-8565-ensemble. The Vite build uses assets/ instead, so the old tree is dead weight. Once a prod deploy has succeeded and the CDN has moved on, delete static/ from the bucket by hand (never with a root-level rsync --delete; datasets/ shares the bucket). See docs/architecture/deploy.md.

Refs WT-1916.

主要语言
JavaScript
星标
21
派生
7
平均合并
6 天 6 小时
30 天内合并 PR
5

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

mozilla/ensemble 的其他 Issue

查看 mozilla/ensemble 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。