filesystem: search_files silently skips a subdirectory it cannot read
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 66/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- typescript
- 领域
- backend
调研方向
Start with searchFilesWithValidation in src/filesystem/lib.ts and trace how its per-entry catch handles validation failures and errors from recursive reads. Compare the failure behavior with directory_tree and list_directory; decide with maintainers whether walking errors should be reported or mark results partial. Done when validation failures remain silently skipped while walking errors are surfaced or the partial result is identified.
由索引模型根据 Issue 内容生成。
描述
Problem
In searchFilesWithValidation (src/filesystem/lib.ts), one try { … } catch { continue; } wraps the per-entry path validation, the match and the recursive descent. The catch is there to skip entries that resolve outside the allowed directories, but it also discards I/O errors such as EACCES from reading a subdirectory. search_files then returns a short result with no sign that it is incomplete, while directory_tree and list_directory report the same failure as an error.
Expected
Only validation failures are skipped silently. An error while walking is either reported, or the result states that it is partial; which of the two is a maintainer's call.
Prior work
- #4910 by @feiiiiii5
The PR(s) above targeted the pre-refactor code and are closed as part of the backlog triage in #4875; this issue is where the work continues, with the PR(s) as a prototype. Thank you to their authors.
- 主要语言
- TypeScript
- 星标
- 91.4k
- 派生
- 11.8k
- 平均合并
- 6 小时 37 分钟
- 30 天内合并 PR
- 147
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
modelcontextprotocol/servers 的其他 Issue
-
chore v2
难度 2/5 1-3 小时 新手友好度 83/100
modelcontextprotocol/servers#5261 ·
维护者通常 1 天内回复
-
docs(git): clarify unconfined default scope and repository confinement options in README and CLI未关闭
难度 2/5 1-3 小时 新手友好度 73/100
modelcontextprotocol/servers#5231 · 1 条评论 ·
维护者通常 1 天内回复
-
docs(git): clarify unconfined default scope and repository confinement options in README and CLI未关闭
难度 1/5 1 小时以内 新手友好度 74/100
modelcontextprotocol/servers#5230 ·
维护者通常 1 天内回复
-
git: README should state plainly that without --repository every reachable repository is in scope未关闭documentation server-git v2
难度 1/5 1-3 小时 新手友好度 84/100
modelcontextprotocol/servers#5225 · 1 条评论 ·
维护者通常 1 天内回复
-
chore v2
难度 2/5 1-3 小时 新手友好度 82/100
modelcontextprotocol/servers#5223 ·
维护者通常 1 天内回复
查看 modelcontextprotocol/servers 的全部 Issue
相似的 Issue
-
type: bug
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
0️⃣ phase/new
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 1/5 1 小时以内 新手友好度 70/100
microsoft/playwright#43640 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100