`logging/setLevel` from one session changes the log level of other sessions

未关闭
  • 哪里不对？
#658 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@atesgoral 已经在做这个了。

开始于 2026年11月6日。

  • #667 来自 @atesgoral —— 未关闭

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
ruby
领域
backend-api-design

调研方向

Start with lib/mcp/server.rb:1386, lib/mcp/server_session.rb:310-314, and lib/mcp/server.rb:448-450 to trace how session and server log levels are applied. The issue suggests updating the server-wide value only when session is nil; check existing logging specs and add coverage for two legacy sessions. Done means setting a level in one session does not change notifications sent to another session that never set a level. An open linked pull request (#667) is already addressing this issue.

由索引模型根据 Issue 内容生成。

描述

bug

Server#configure_logging_level sets the level on the calling session, then always sets the server-wide @logging_message_notification too (server.rb:1386).

Legacy sessions that did not set their own level fall back to that server-wide value (server_session.rb:310-314), and Server#notify_log_message uses it for broadcasts (server.rb:448-450). So when one client calls logging/setLevel, every other legacy session without its own level starts to get notifications/message at that level. This includes sessions created later.

The spec treats the log level as a preference of the connection that sets it. The modern lifecycle is not affected, because it uses the per-request logLevel from the envelope.

Repro

Run from the repository root with bundle exec ruby -I lib repro.rb:

require "mcp"

class RecordingTransport
  attr_reader :log_messages

  def initialize
    @log_messages = []
  end

  def send_notification(method, params = nil, session_id: nil, **)
    @log_messages << [session_id, params["data"]] if method == "notifications/message"
    true
  end
end

log_tool = MCP::Tool.define(name: "log_tool") do |server_context:|
  server_context.notify_log_message(data: "debug detail", level: "debug")
  MCP::Tool::Response.new([{ type: "text", text: "ok" }])
end
transport = RecordingTransport.new
server = MCP::Server.new(name: "example", tools: [log_tool])
server.transport = transport

initialize_request = {
  jsonrpc: "2.0", id: 1, method: "initialize",
  params: { protocolVersion: "2025-11-25", capabilities: {}, clientInfo: { name: "client", version: "1" } },
}
session_a = MCP::ServerSession.new(server: server, transport: transport, session_id: "A")
session_b = MCP::ServerSession.new(server: server, transport: transport, session_id: "B")
session_a.handle(initialize_request)
session_b.handle(initialize_request)

session_a.handle({ jsonrpc: "2.0", id: 2, method: "logging/setLevel", params: { level: "debug" } })
session_b.handle({ jsonrpc: "2.0", id: 3, method: "tools/call", params: { name: "log_tool", arguments: {} } })

p transport.log_messages

Expected: []. Session B never called logging/setLevel.

Actual: [["B", "debug detail"]]

Suggested fix

Set the server-wide value only on the session-less path (session is nil). With a session, change only that session's level. Applications can still set a server-wide default with Server#logging_message_notification=.

主要语言
Ruby
星标
940
派生
143
平均合并
1 天 3 小时
30 天内合并 PR
47

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

modelcontextprotocol/ruby-sdk 的其他 Issue

查看 modelcontextprotocol/ruby-sdk 的全部 Issue

相似的 Issue

更多 Ruby Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。