[Server] Answer arguments the input schema refuses with an `isError` result from revision 2025-11-25 on

未关闭
#763 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@falisco 已经在做这个了。

开始于 2026年11月21日。

  • #764 来自 @falisco —— 未关闭

评估

难度
3/5
预计耗时
1-2 天
新手友好度
25/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
json, php
领域
api

调研方向

Start in src/Server/Handler/Request/CallToolHandler.php, where schema validation runs before the tool and returns Error::forInvalidParams(); the ToolCallException branch and validateStructuredContent() show how an isError CallToolResult is built. The change is gated on the negotiated protocol revision, so check how the session version is available there and cover both 2025-06-18 and 2025-11-25 in tests. Done when a schema mismatch on 2025-11-25 returns an isError result and older revisions still return -32602. A pull request (#764) is already open against this issue, so coordinate with it first.

由索引模型根据 Issue 内容生成。

描述

Description

CallToolHandler validates the arguments of tools/call against the tool's input schema before the tool runs, and answers a mismatch with the JSON-RPC error -32602 (Error::forInvalidParams(), with the validation errors in data).

I know this is the documented behaviour: docs/servers/schemas.md ("Argument Validation") shows that exact error, and the 0.10.0 changelog says "arguments that don't fit are answered with -32602". It also matches the 2025-06-18 revision, whose "Error Handling" lists "Invalid arguments" under Protocol Errors.

The specification moved that case in 2025-11-25, though. "Error Handling" of Tools now lists "Input validation errors (e.g., date in wrong format, value out of range)" under Tool Execution Errors, reported in the result with isError: true, and keeps only unknown tools, malformed requests and server errors as protocol errors. It gives the reason: tool execution errors "contain actionable feedback that language models can use to self-correct and retry with adjusted parameters", and clients SHOULD pass them to the model, while they only MAY pass protocol errors. The 2026-07-28 text keeps it that way.

So on a session that negotiated 2025-11-25, the same kind of mistake by a model has two outcomes:

  • a value the tool refuses (ToolCallException) comes back as a result with isError: true;
  • a value the schema refuses (a pattern, an enum, a range, a missing property) comes back as a protocol error, and whether the model ever reads "String does not match the required pattern" is up to the client.

#515 made the same choice for the other direction: an output that does not match outputSchema is answered as an isError result so that the model sees what went wrong.

I met it on the MCP server of a card game: a card that exists but is not legal comes back as a refusal the model can read, with the legal cards, while a card written in lower case comes back as a protocol error.

Versions

mcp/sdk v0.10.0, PHP 8.5.12. src/Server/Handler/Request/CallToolHandler.php is the same on main (7155eaee). Also seen on v0.9.0.

How to reproduce
<?php

require __DIR__.'/vendor/autoload.php';

use Mcp\Server\Capability\Attribute\Schema;
use Mcp\Server\Exception\ToolCallException;
use Mcp\Server\Server;
use Mcp\Server\Transport\StdioTransport;

final class Letters
{
    public function shout(#[Schema(pattern: '^[A-Z]$')] string $letter): string
    {
        if ('Z' === $letter) {
            throw new ToolCallException('Z is not allowed today, pick another capital letter.');
        }

        return $letter.'!';
    }
}

Server::builder()
    ->setServerInfo('letters', '1.0.0')
    ->addTool([Letters::class, 'shout'], 'shout')
    ->build()
    ->run(new StdioTransport());
printf '%s\n' \
  '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2025-11-25","capabilities":{},"clientInfo":{"name":"repro","version":"1"}}}' \
  '{"jsonrpc":"2.0","method":"notifications/initialized"}' \
  '{"jsonrpc":"2.0","id":2,"method":"tools/call","params":{"name":"shout","arguments":{"letter":"Z"}}}' \
  '{"jsonrpc":"2.0","id":3,"method":"tools/call","params":{"name":"shout","arguments":{"letter":"a"}}}' \
  | php repro.php

Refused by the tool (id 2):

{"jsonrpc":"2.0","id":2,"result":{"content":[{"type":"text","text":"Z is not allowed today, pick another capital letter."}],"isError":true}}

Refused by the schema (id 3):

{"jsonrpc":"2.0","id":3,"error":{"code":-32602,"message":"Invalid parameters for tool 'shout': Property '\/letter': String does not match the required pattern: `^[A-Z]$`.","data":{"validation_errors":[{"pointer":"\/letter","keyword":"pattern","message":"String does not match the required pattern: `^[A-Z]$`."}]}}}
Expected

On a session at 2025-11-25 or later, a result the model can read for id 3:

{"jsonrpc":"2.0","id":3,"result":{"content":[{"type":"text","text":"Invalid parameters for tool 'shout': Property '\/letter': String does not match the required pattern: `^[A-Z]$`."}],"isError":true}}
Possible solution

In CallToolHandler, when the schema validation fails and the negotiated revision is 2025-11-25 or later, return new Response($request->getId(), CallToolResult::error([new TextContent($summaryMessage)])), as the ToolCallException branch and validateStructuredContent() already do. Sessions on 2025-06-18 and before keep -32602, as their revision says; an unknown tool and a request that is not a valid CallToolRequest stay protocol errors on every revision.

Was -32602 kept on purpose for the newer revisions? I found no note on it in the changelog or around the validation block. If the change is welcome I can send a pull request, with the docs page and a [BC Break] changelog entry.

主要语言
PHP
星标
1.7k
派生
206
平均合并
1 天 19 小时
30 天内合并 PR
100

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

modelcontextprotocol/php-sdk 的其他 Issue

查看 modelcontextprotocol/php-sdk 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。