Add timeout and fallback logging for closeGracefully() to prevent hanging shutdown
还没有人认领这个 Issue。
评估
调研方向
先阅读 McpAsyncClient.closeGracefully(),然后检查 initializer.closeGracefully() 和 transport.closeGracefully(),以了解它们的完成行为。确认超时处理、警告和作为 fallback 的强制关闭、错误处理以及最终完成能够使关闭过程有界,同时不改变预期的 graceful 路径。
由索引模型根据 Issue 内容生成。
描述
Problem
When using McpAsyncClient.closeGracefully(), the client executes:
return this.initializer.closeGracefully()
.then(transport.closeGracefully());
Both initializer.closeGracefully() and transport.closeGracefully() return Mono<Void>.
However, if either of them hangs—for example:
- The underlying transport (HTTP/SSE/WebSocket) never completes
- The server doesn’t respond to shutdown
- A Reactor pipeline remains open (no
onComplete)
then the returned Mono never completes, causing the application to hang indefinitely during shutdown.
This results in JVMs or containers that never terminate, blocking CI/CD or production deployments.
Goal
Add a timeout and fallback mechanism to ensure that the client always terminates safely, even when the transport or initializer fails to complete.
Proposed Change
1. Wrap shutdown calls with timeout and fallback
Use Reactor’s timeout(Duration, fallbackMono) operator to guarantee a bounded shutdown duration.
public Mono<Void> closeGracefully() {
return Mono.defer(() -> {
long start = logger.isDebugEnabled() ? System.nanoTime() : 0L;
Duration timeout = Duration.ofSeconds(
Integer.getInteger("mcp.shutdown.timeout.seconds", 10));
Mono<Void> graceful = this.initializer.closeGracefully()
.then(transport.closeGracefully());
Mono<Void> fallback = Mono.fromRunnable(() -> {
logger.warn("closeGracefully() timed out after {} seconds; proceeding with best-effort shutdown.", timeout.getSeconds());
try {
this.transport.close(); // force-close if needed
} catch (Throwable t) {
logger.warn("Fallback forced close encountered error: {}", t.toString());
}
})
.then();
return graceful
.timeout(timeout, fallback)
.doOnError(e -> logger.warn("closeGracefully() failed: {}", e.toString()))
.onErrorResume(e -> Mono.empty()) // ensure app doesn't hang
.doFinally(sig -> {
if (logger.isDebugEnabled()) {
long durationMs = (System.nanoTime() - start) / 1_000_000;
logger.debug("closeGracefully() finished with signal={}, took {} ms", sig, durationMs);
}
});
});
}
Summary
Introduce a timeout and fallback mechanism for closeGracefully() to guarantee reliable termination, preventing hanging shutdowns when the transport or lifecycle initializer fails to complete.
- 主要语言
- Java
- 星标
- 3.7k
- 派生
- 1.1k
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 9
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
modelcontextprotocol/java-sdk 的其他 Issue
-
area/transport bug P2
难度 2/5 1-3 小时 新手友好度 88/100
modelcontextprotocol/java-sdk#1136 ·
-
area/client bug P2
难度 2/5 1-3 小时 新手友好度 84/100
modelcontextprotocol/java-sdk#1124 · 1 条评论 ·
-
ServerCapabilities.logging is added unconditionally, overriding the caller's explicit capabilities 未关闭bug P2 ready for work
难度 2/5 1-3 小时 新手友好度 68/100
modelcontextprotocol/java-sdk#1086 · 1 条评论 ·
-
enhancement good first issue P3
难度 2/5 1-3 小时 新手友好度 82/100
modelcontextprotocol/java-sdk#1067 ·
-
bug P2 ready for work
难度 2/5 1-3 小时 新手友好度 74/100
modelcontextprotocol/java-sdk#898 · 1 条评论 ·
查看 modelcontextprotocol/java-sdk 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
elastic/gradle-plugins#157 ·
-
enhancement Tools
难度 1/5 1 小时以内 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100
apache/rocketmq-dashboard#5008 ·
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
-
DETECT_PARAMETER_NAMES=false silently disables @ConstructorProperties-based Creator detection too 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
FasterXML/jackson-databind#6229 ·