UserType discrepancy between enum value and Graph API response

未关闭
#1,736 1 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
php
领域
api

调研方向

从生成的 Microsoft\Graph\Generated\Models\UserType enum 开始,将其 MEMBER 值与 issue 中显示的 Microsoft Graph user endpoint 响应进行比较。检查其他 SDK enum 常量是否存在相同类型的不一致。完成的标准是 UserType 与 API 匹配,并且已识别和修正发现的任何其他差异。

由索引模型根据 Issue 内容生成。

描述

service bug
Describe the bug

The following Microsoft Graph API endpoint:
https://graph.microsoft.com/v1.0/users/{{azureUserId}}?$select=userType

returns

{
  "@odata.context": "https://graph.microsoft.com/v1.0/$metadata#users(userType)/$entity",
  "userType": "Member"
}

However, the Microsoft\Graph\Generated\Models\UserType generated enum of the SDK contains
public const MEMBER = "member";

If an integration intends to proactively remove non-member type users from the system using code such as:

if ($azureUser->getUserType() !== UserType::MEMBER) {
    $azureUser->delete();
}

this risks removing all Azure users from the system, because an Azure user of user type member would satisfy this condition as well ('member' !== 'Member' is true).

Note: This discrepancy between the API response and the generated SDK has triggered an incident in a production environment of a software product, because the unit tests use the UserType value from the SDK.

Expected behavior

The UserType enum/const should have values capitalized.
Any other enum/consts contained in the SDK should be reviewed for correctness to be in-line with the actual API responses.

How to reproduce

See issue description. There's discrepancy between the API response and the SDK enum/const value.

SDK Version

"microsoft/microsoft-graph": "^2.3",

Latest version known to work for scenario above?

None.

Known Workarounds

Not using UserType, hardcoding sentence-cased value.

Debug output
Click to expand log ```
</details>


### Configuration

_No response_

### Other information

_No response_
主要语言
PHP
星标
669
派生
149
平均合并
1 天 4 小时
30 天内合并 PR
5

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

microsoftgraph/msgraph-sdk-php 的其他 Issue

查看 microsoftgraph/msgraph-sdk-php 的全部 Issue

相似的 Issue

更多 PHP Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。