Preserve JSONRPC request IDs and correctly parse bounded multi-header frames
还没有人认领这个 Issue。
评估
调研方向
Read request dispatch and framing in crates/pet-jsonrpc/src/server.rs, then reply serialization in crates/pet-jsonrpc/src/lib.rs; start with the injectable reader/writer seam from dependency #529. Add deterministic cases for fragmented and coalesced frames, IDs, malformed input, and size limits, using existing fuzz/property tooling where practical. Done means IDs round-trip, framing remains compatible, and invalid input cannot panic or lose requests.
由索引模型根据 Issue 内容生成。
描述
Tracking plan: #528
Priority: P2. Evidence: reproduced on Windows at 4e523ba.
Problem
The transport/dispatcher assumes a single Content-Length header, treats non-u64 request IDs as notifications, and narrows u64 IDs to u32. A bounded harness sent a valid control info request before each case and observed:
| Input | Actual behavior |
|---|---|
Numeric ID 4294967297 |
Response ID 1 |
String ID audit-1 |
No response within 600 ms; routed as notification |
| Optional Content-Type header before the blank separator | No response within 600 ms; payload framing misparsed |
Sources: request dispatch, framing, reply serialization.
The payload length is also used directly for allocation without a documented upper bound.
Scope
- Parse framed headers through the blank line; support optional Content-Type and partial reads without losing subsequent frames.
- Represent supported request IDs without truncation across dispatch, refresh joiners, replies, and errors. Distinguish absent IDs from invalid IDs and valid string/numeric IDs.
- Validate protocol messages and frame size, returning appropriate explicit errors or a documented connection-close outcome where framing cannot be recovered.
- Update the documented supported JSONRPC/framing contract rather than silently broadening or narrowing behavior.
Acceptance criteria
- String and large integer request IDs round-trip unchanged, including coalesced refresh replies and errors.
- Tests cover extra headers, consecutive frames, fragmented header/payload reads, non-ASCII payload byte lengths, and clean/truncated EOF.
- Malformed JSON, invalid request shapes/IDs, invalid lengths, and oversized frames cannot panic, trigger unbounded allocation, or silently lose a request.
- Existing VS Code-style clients and environment/manager notifications remain compatible.
- Fuzz/property-style parser cases are added using existing tooling where practical; deterministic regression cases are mandatory.
Dependencies
Depends on #529 to reuse its injectable reader/writer seam. The complete landing order is in #528. This is separate from the already-fixed stdout logging contamination in #341.
- 主要语言
- Rust
- 星标
- 207
- 派生
- 45
- 平均合并
- 3 天 6 小时
- 30 天内合并 PR
- 12
贡献指南
这个仓库没有索引到贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/python-environment-tools 的其他 Issue
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
-
debt
难度 5/5 一周以上 新手友好度 25/100
microsoft/python-environment-tools#538 · 1 条评论 ·
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
-
debt
难度 5/5 一周以上 新手友好度 35/100
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
microsoft/python-environment-tools#533 · 2 条评论 ·
查看 microsoft/python-environment-tools 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 88/100
-
bug core
难度 2/5 1-3 小时 新手友好度 86/100
-
JIT-compiled number -> Decimal conversion silently overflows instead of raising DECIMAL_OVERFLOW 未关闭fuzz
难度 2/5 1-3 小时 新手友好度 82/100
ClickHouse/ClickHouse#122114 ·
-
难度 1/5 1 小时以内 新手友好度 92/100
linebender/vello_svg#90 ·
-
难度 2/5 1-3 小时 新手友好度 74/100