[Bug]: Firefox: `page.emulateMedia({ contrast })` updates `matchMedia()` but never restyles the page
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 44/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- playwright, typescript
调研方向
Start with the Firefox patch in browser_patches/firefox/patches/bootstrap.diff, especially the DidSet for PrefersContrastOverride, and compare it with Firefox’s PrefersReducedMotionOverride notification behavior. The reproduction is a single Playwright test file linked in the issue; run it to confirm that matchMedia() changes while computed styles do not. Done means Firefox restyles the page after emulateMedia({ contrast: 'more' }), with the reproduction passing.
由索引模型根据 Issue 内容生成。
描述
Version
1.64.1, Firefox 157.0 (build 1555). Also 1.63.0; the patch in question is unchanged on main as of 9c5ba13d8.
Steps to reproduce
- Clone https://github.com/k35o/playwright-firefox-contrast-repro
npm install && npx playwright install chromium firefox webkitnpx playwright test
The whole reproduction is this one test file:
import { test, expect } from '@playwright/test';
const html = `
<style>
p { color: rgb(0, 0, 0); }
@media (prefers-contrast: more) { p { color: rgb(255, 0, 0); } }
@media (prefers-reduced-motion: reduce) { p { background-color: rgb(0, 0, 255); } }
</style>
<p>text</p>
`;
test('emulateMedia({ contrast }) restyles the page', async ({ page }) => {
await page.setContent(html);
await expect(page.locator('p')).toHaveCSS('color', 'rgb(0, 0, 0)');
await page.emulateMedia({ contrast: 'more' });
// The media query itself reports the new value...
expect(await page.evaluate(() => matchMedia('(prefers-contrast: more)').matches)).toBe(true);
// ...but in Firefox the computed style never follows.
await expect(page.locator('p')).toHaveCSS('color', 'rgb(255, 0, 0)');
});
test('emulateMedia({ reducedMotion }) restyles the page (control)', async ({ page }) => {
await page.setContent(html);
await expect(page.locator('p')).toHaveCSS('background-color', 'rgba(0, 0, 0, 0)');
await page.emulateMedia({ reducedMotion: 'reduce' });
expect(await page.evaluate(() => matchMedia('(prefers-reduced-motion: reduce)').matches)).toBe(true);
await expect(page.locator('p')).toHaveCSS('background-color', 'rgb(0, 0, 255)');
});
Expected behavior
The @media (prefers-contrast: more) rule applies as soon as emulateMedia({ contrast: 'more' }) resolves, as it does in Chromium and WebKit, and as reducedMotion does in Firefox.
Actual behavior
In Firefox (157.0, r1555), the first test fails; the control passes:
Error: expect(locator).toHaveCSS(expected) failed
Locator: locator('p')
Expected: "rgb(255, 0, 0)"
Received: "rgb(0, 0, 0)"
Timeout: 5000ms
matchMedia('(prefers-contrast: more)').matches is already true, but the computed style keeps the old value however long you wait. The new value only takes effect when something else makes Firefox re-evaluate media features, e.g. a later emulateMedia({ media: 'print' }). Because of that, the outcome of a test can depend on what an earlier test or hook left pending, which is how we found it: a print-styles test passed or failed in Firefox depending on whether the previous test's afterEach had just switched media back.
Setting the value on the context instead (use: { contrast: 'more' } or browser.newContext({ contrast: 'more' })) works, since the page is styled after the override is in place.
Additional context
I think the cause is in browser_patches/firefox/patches/bootstrap.diff. The DidSet for the added PrefersContrastOverride field only calls PresContextAffectingFieldChanged():
PresContextAffectingFieldChanged() runs nsPresContext::RecomputeBrowsingContextDependentData(), which re-reads zoom, color scheme, forced colors and medium, but not contrast, so nothing calls MediaFeatureValuesChanged() and the style is never invalidated. matchMedia() evaluates the query on demand, which is why it already reports the new value.
Upstream's own PrefersReducedMotionOverride, the closest analogue, notifies the pres contexts itself:
Doing the same for contrast should fix it. I haven't built the patched Firefox to verify this:
void BrowsingContext::DidSet(FieldIndex<IDX_PrefersContrastOverride>,
dom::PrefersContrastOverride aOldValue) {
MOZ_ASSERT(IsTop());
if (PrefersContrastOverride() == aOldValue) {
return;
}
WalkPresContexts([&](nsPresContext* aPc) {
aPc->MediaFeatureValuesChanged(
{MediaFeatureChangeReason::PreferenceChange},
MediaFeatureChangePropagation::JustThisDocument);
});
}
Environment
System:
OS: macOS 27.2
CPU: (10) arm64 Apple M4
Binaries:
Node: 26.12.1
npm: 11.20.0
npmPackages:
@playwright/test: 1.64.1 => 1.64.1
- 主要语言
- TypeScript
- 星标
- 99.1k
- 派生
- 6.8k
- 平均合并
- 16 小时 56 分钟
- 30 天内合并 PR
- 299
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/playwright 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 82/100
microsoft/playwright#43998 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
microsoft/playwright#43990 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 35/100
microsoft/playwright#43999 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 69/100
microsoft/playwright#43996 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
microsoft/playwright#43995 ·
维护者通常 1 天内回复
查看 microsoft/playwright 的全部 Issue
相似的 Issue
-
code-quality good-first-issue
难度 2/5 1-3 小时 新手友好度 72/100
OpenRailAssociation/netzgrafik-editor-frontend#1481 ·
维护者通常 1 天内回复
-
bug implicit-state
难度 2/5 1-3 小时 新手友好度 74/100
-
area:models enhancement
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
bug frontend ui
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
Recording drops clicks on links, filters and checkboxes that share a form with a search field可能已有人在做 @columbia11 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
Tencent/BrowserSkill#657 ·
维护者通常 1 天内回复