[BUG] WebKit (Linux): Assertion error in WKPage._onTargetCreated on a cross-site redirect chain

未关闭
#43,067 5 条评论 0 个 reaction 已指派 1 人 在 GitHub 查看

维护者通常 1 天内回复

@yury-s 已经在做这个了。

开始于 2026年10月6日。

  • #43068 来自 @MO2k4 —— 已关闭,未合并
  • #43233 来自 @yury-s —— 已关闭,未合并

评估

难度
3/5
预计耗时
1-2 天
新手友好度
72/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
领域
testing-qa

调研方向

Start at WKPage._onTargetCreated and inspect the page-goto.spec.ts regression test named “should work with cross-process redirect chain through visited sites.” Reproduce the Linux WebKit redirect chain with repro.mjs, then verify the assertion is avoided and navigation reaches /done while the regression test passes.

由索引模型根据 Issue 内容生成。

描述

browser-webkit milestone
Version

1.63.0 (WebKit r2359); also current main (WebKit r2369). 1.64.0-alpha-2026-10-02 is affected as well.

Environment
  • Linux: mcr.microsoft.com/playwright:v1.63.0-noble, GitHub ubuntu-24.04 runners. Headless, and headed under xvfb-run.
  • macOS (WebKit r2369): not affected.
Steps to reproduce

Three loopback hosts act as three sites: localhost (C), 127.0.0.1 (B), [::1] (A).
The page visits C → B → A by clicking links. A form on A then posts to /go, which returns a 302 to B/hop, which returns a 302 to C/done.

// repro.mjs: node repro.mjs   (env: VARIANT=get, PRE=c,b (default), N=3, HEADED=1)
import http from 'node:http';
import { webkit } from 'playwright';

const PORT = 8123;
const H = { a: '[::1]', b: '127.0.0.1', c: 'localhost' };
const method = process.env.VARIANT === 'get' ? 'get' : 'post';
const pre = (process.env.PRE ?? 'c,b').split(',').filter(Boolean);
const server = http.createServer((req, res) => {
  const u = new URL(req.url, `http://${req.headers.host}`);
  const next = u.searchParams.get('next');
  if (u.pathname === '/page') {
    res.writeHead(200, { 'content-type': 'text/html' });
    const href = next ? `http://${H[next.split(',')[0]]}:${PORT}/page?next=${next.split(',').slice(1).join(',')}` : '/form';
    res.end(next ? `<a href="${href}">next</a>` : `<form method="${method}" action="/go"><button>go</button></form>`);
  } else if (u.pathname === '/go') {
    req.resume(); res.writeHead(302, { location: `http://${H.b}:${PORT}/hop` }); res.end();
  } else if (u.pathname === '/hop') {
    res.writeHead(302, { location: `http://${H.c}:${PORT}/done` }); res.end();
  } else {
    res.writeHead(200, { 'content-type': 'text/html' }); res.end('<h1>done</h1>');
  }
});
await new Promise(r => server.listen(PORT, '::', r));
const browser = await webkit.launch({ headless: !process.env.HEADED });
let fails = 0;
const N = Number(process.env.N || 3);
for (let i = 0; i < N; i++) {
  const page = await browser.newPage();
  try {
    const hosts = [...pre, 'a'];
    await page.goto(`http://${H[hosts[0]]}:${PORT}/page?next=${hosts.slice(1).join(',')}`);
    for (let k = 1; k < hosts.length; k++) {
      await page.getByRole('link', { name: 'next' }).click();
      await page.waitForURL(url => url.host.startsWith(H[hosts[k]]));
    }
    await page.getByRole('button', { name: 'go' }).click();
    await page.waitForURL(/\/done$/, { timeout: 10_000 });
    console.log(`run ${i}: ok ${page.url()}`);
  } catch (e) {
    fails++; console.log(`run ${i}: FAIL ${String(e.message).split('\n')[0]}`);
  }
  await page.close().catch(() => {});
}
console.log(`variant=${method} pre=${pre.join('>')}>a fails=${fails}/${N}`);
await browser.close(); server.close();
docker run --rm --ipc=host -v "$PWD":/w -w /w mcr.microsoft.com/playwright:v1.63.0-noble \
  bash -c 'npm i --silent [email protected] >/dev/null && node repro.mjs'
Expected behavior

The page lands on http://localhost:8123/done, as it does on macOS.

Actual behavior

On the first run, the driver process crashes with an unhandled assertion:

Error: Assertion error
    at assert (playwright-core/lib/coreBundle.js:838)
    at _WKPage._onTargetCreated (playwright-core/lib/coreBundle.js:47026)
    at WKSession.emit ...

In the test runner, the assertion is swallowed and the navigation times out instead.

It reproduces with POST and with GET. It does not reproduce when only one of B and C was visited before, or neither (PRE=b, PRE=).

Analysis

Protocol sequence on Linux:

Target.targetCreated page-25 {isProvisional:true}   // swap #1, after the 302 from A to B
[page-25] requestWillBeSent http://127.0.0.1/hop
[page-25] Page.willCheckNavigationPolicy
Target.targetCreated page-28 {isProvisional:true}   // swap #2 while page-25 is still provisional -> assert(!this._provisionalPage)
Target.targetDestroyed page-25                       // old provisional target is destroyed only after the new one is created

On macOS, provisional page-30 follows the /hop → /done redirect itself and commits, so there is no second swap.
On Linux, WebKit swaps processes again for the redirect target before the first provisional page commits, and it creates the new target before it destroys the old one.
WKPage._onTargetCreated asserts that no provisional page exists yet.

This is a different cause from #37766 (a WebKit SIGABRT on reload) and #42957 (COOP). No COOP/COEP headers are involved.

Proposed fix

In WKPage._onTargetCreated, when a provisional target arrives while _provisionalPage is set, dispose the stale provisional page instead of asserting.
The targetDestroyed that follows for the old id then matches nothing and is a no-op.
A PR with this fix and a regression test (page-goto.spec.ts › should work with cross-process redirect chain through visited sites) follows.

主要语言
TypeScript
星标
100k
派生
6.9k
平均合并
16 小时 8 分钟
30 天内合并 PR
281

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

microsoft/playwright 的其他 Issue

查看 microsoft/playwright 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。