LLM audit
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 需要澄清
- 活跃度
- 冷清
- 技术栈
- c
调研方向
首先检查列出的源代码位置,并将报告的每个行为与所引用的声明、调用方和文档进行比较。在相关平台上分别确认疑似问题;当每项发现要么有针对性的复现支持,要么被排除为误报时,工作即告完成。
由索引模型根据 Issue 内容生成。
描述
I want to make use of mimalloc in rustc, so I did an LLM audit on dev3 branch, commit e6997f583d17a3d3e2a9785eebc1e35b85503012. I've found LLMs quite good at spotting bugs, though with some false positives. Most false positives they surface seems worthy of a comment to guide both LLMs and humans in the right direction however. I've only looked at a couple of these so they are not all confirmed bugs.
List of bugs
High
Issue 5: Non-Windows _aligned_malloc wrapper swaps size and alignment [Looks like a false positive, but comment worthy]
- Severity: High
- Location:
src/alloc-override.c:360-361 - Details: The compatibility wrapper is declared as
_aligned_malloc(size_t alignment, size_t size)and forwardsmi_aligned_alloc(alignment, size), so callers using_aligned_malloc(size, alignment)can receive undersized allocations. - Evidence:
src/alloc-override.c:186-187,360-361;include/mimalloc-override.h:59
Medium
Issue 9: mi_manage_memory swaps is_pinned and is_zero
- Severity: Medium
- Location:
src/arena.c:1656-1664 - Details: The public declaration uses
(..., is_pinned, is_zero, ...), but the definition uses(..., is_zero, is_pinned, ...), reversing runtime semantics for pinned and zero-initialized managed memory. - Evidence:
include/mimalloc.h:401-403;src/arena.c:1656-1664
Issue 24: Deferred free callback/arg publication race
- Severity: Medium
- Location:
src/page.c:883-897 - Details:
deferred_freeis published beforedeferred_argand read without matching acquire semantics, so concurrent registration can invoke the new callback with stale context. - Evidence:
src/page.c:883-897;src/page.c:987-991
Issue 27: Fallback constructor misbinds main allocator to dlopen() thread
- Severity: Medium
- Location:
src/prim/prim.c:30-45 - Details: The fallback constructor runs
_mi_auto_process_init()on whichever thread loads the library, so a worker thread can become the recorded "main" allocator thread and later tear down static main-thread state when it exits. - Evidence:
src/prim/prim.c:30-45;src/init.c:965-977
Issue 40: ETW provider is never unregistered on unload
- Severity: Medium
- Location:
src/prim/windows/etw.h:733-741 - Details: ETW registration happens during process init, but the Windows detach path never calls
EventUnregistermicrosoft_windows_mimalloc(), and the generated ETW header explicitly warns that unload without unregister can crash. - Evidence:
include/mimalloc/track.h:78-87;src/init.c:1112-1158;src/prim/windows/etw.h:733-741
Low
Issue 2: Broken once primitive allows partial initialization escape
- Severity: Low
- Location:
include/mimalloc/atomic.h:343-350 - Details:
mi_atomic_onceonly performs a 0->1 CAS and does not wait for initialization completion, so racing threads can proceed while process/TLS initialization is still incomplete. - Evidence:
include/mimalloc/atomic.h:343-350;src/init.c:696-704;include/mimalloc/prim.h:470-486
Issue 3: BMI1 mi_bsr fast path returns lzcnt, not the MSB index
- Severity: Low
- Location:
include/mimalloc/bits.h:275-285 - Details: The BMI1 branch stores the raw
lzcntresult into*idxinstead of converting it toMI_SIZE_BITS - 1 - lzcnt(x), so callers get mirrored bit indexes. - Evidence:
include/mimalloc/bits.h:275-285;src/bitmap.c:952-971
Issue 4: Invalid pthread TLS key use in macOS PowerPC fallback
- Severity: Low
- Location:
include/mimalloc/prim.h:185-187 - Details: The Apple PowerPC fallback passes fixed TLS slot numbers to
pthread_getspecificandpthread_setspecificeven though nopthread_key_createkey exists for those values. - Evidence:
include/mimalloc/prim.h:185-187,225-227
Issue 6: realloc_aligned_at drops the offset requirement for small alignments
- Severity: Low
- Location:
src/alloc-aligned.c:329-340 - Details:
mi_theap_realloc_zero_aligned_atfalls back to generic realloc whenalignment <= sizeof(uintptr_t)and ignoresoffset, so the returned pointer can violate the documented((uintptr_t)p + offset) % alignment == 0contract. - Evidence:
src/alloc-aligned.c:329-340;doc/mimalloc-doc.h:320-334
Issue 7: mi_reallocarr violates NetBSD zero-count semantics
- Severity: Low
- Location:
src/alloc-posix.c:113-126 - Details: Zero-sized
reallocarrrequests are forwarded tomi_realloc(p, 0), but mimalloc intentionally returns a zero-sized allocation instead of freeing and nulling the pointer as NetBSDreallocarrrequires. - Evidence:
src/alloc-posix.c:113-126;src/alloc.c:361-405
Issue 8: mi_theap_realpath leaks a foreign realpath buffer
- Severity: Low
- Location:
src/alloc.c:552-562 - Details: The POSIX path duplicates
realpath(fname, NULL)into mimalloc memory and then callsmi_cfreeon the original, butmi_cfreeignores non-mimalloc allocations. - Evidence:
src/alloc.c:552-562;src/alloc-posix.c:49-53
Issue 12: _mi_bitmap_forall_setc_rangesn can ignore an early stop request
- Severity: Low
- Location:
src/bitmap.c:1497-1518 - Details: If
visit(...)returnsfalsewhileskipped == 0, the function does not return immediately and can continue clearing and visiting later ranges. - Evidence:
src/bitmap.c:1497-1518;src/bitmap.h:214-226
Issue 13: Wrong debug assertion bound in tail chunk path
- Severity: Low
- Location:
src/bitmap.c:1050-1076 - Details: The assertion checks
chunk_idx < MI_BCHUNK_FIELDSeven thoughchunk_idxindexes the chunk array, so valid large bitmaps can trip it in debug builds. - Evidence:
src/bitmap.c:1050-1076;src/bitmap.h:70-87
Issue 15: Subprocess teardown can self-deadlock
- Severity: Low
- Location:
src/init.c:545-556 - Details:
mi_subprocs_unsafe_destroy_all()holdssubprocs_lockand callsmi_subproc_unsafe_destroy(), which immediately re-locks the same non-recursive mutex. - Evidence:
src/init.c:498-505,545-556
Issue 17: Partial huge-page allocation records the requested size instead of the actual size
- Severity: Low
- Location:
src/os.c:733-795 - Details: On partial success,
*psizeis reduced butmemid.mem.os.sizestays at the original request, soMI_MEM_OS_HUGEfree/accounting paths later use the wrong span. - Evidence:
src/os.c:733-795;src/os.c:249-272
Issue 18: Output callback registration races with output emission
- Severity: Low
- Location:
src/options.c:403-416 - Details: The output callback and callback argument are not atomically published as a pair, so concurrent readers can observe a new callback with an old argument.
- Evidence:
src/options.c:403-416;src/options.c:470-476
Issue 19: Error callback registration races with error delivery
- Severity: Low
- Location:
src/options.c:599-613 - Details:
mi_register_error()and_mi_error_message()access the handler pointer without synchronization, and the handler/arg pair can be observed in a mixed state. - Evidence:
src/options.c:574-575,599-613
Issue 20: Boolean environment parser accepts arbitrary substrings
- Severity: Low
- Location:
src/options.c:645-655 - Details: The parser uses substring search against
1;TRUE;YES;ONand0;FALSE;NO;OFF, so malformed values likeRUE,AL, or;are accepted as valid booleans. - Evidence:
src/options.c:645-655
Issue 23: mi_good_size can overflow and return a smaller-than-requested value
- Severity: Low
- Location:
src/page-queue.c:114-120 - Details: The function adds padding and aligns without overflow checks, so near-
SIZE_MAXinputs can wrap and violate the documentedn >= sizecontract. - Evidence:
src/page-queue.c:114-120;doc/mimalloc-doc.h:272-281
Issue 25: malloc_zone_from_ptr always returns mimalloc's zone
- Severity: Low
- Location:
src/prim/osx/alloc-override-zone.c:330-333 - Details:
zone_from_ptr()ignores its pointer argument and always reports the default mimalloc zone, so callers can misroute foreign pointers into mimalloc's zone free/realloc path. - Evidence:
src/prim/osx/alloc-override-zone.c:330-333;src/prim/osx/alloc-override-zone.c:380-391
Issue 26: Lazy zone registration is racy
- Severity: Low
- Location:
src/prim/osx/alloc-override-zone.c:245-265 - Details:
mi_get_default_zone()uses an unsynchronized staticinitflag aroundmalloc_zone_register, allowing duplicate registration races during concurrent startup. - Evidence:
src/prim/osx/alloc-override-zone.c:245-265
Issue 28: Linux physical-memory detection ignores sysinfo.mem_unit
- Severity: Low
- Location:
src/prim/unix/prim.c:184-190 - Details: The Linux path divides
info.totalramdirectly byMI_KiB, buttotalramis expressed inmem_unitunits rather than bytes. - Evidence:
src/prim/unix/prim.c:184-190
Issue 31: Windows large-page one-time initialization is racy
- Severity: Low
- Location:
src/prim/windows/prim.c:93-128 - Details:
win_enable_large_os_pages()uses a plain staticlarge_initializedguard, so concurrent callers can race and observe incomplete setup. - Evidence:
src/prim/windows/prim.c:93-128;src/prim/windows/prim.c:412-416
Issue 32: Huge-page availability cache is racy
- Severity: Low
- Location:
src/prim/windows/prim.c:420-438 - Details:
_mi_prim_alloc_huge_os_pagesx()uses a shared plain staticmi_huge_pages_availableflag without synchronization, so concurrent callers can race and disable attempts nondeterministically. - Evidence:
src/prim/windows/prim.c:420-438
Issue 33: NULL stderr handle is misclassified as usable
- Severity: Low
- Location:
src/prim/windows/prim.c:593-616 - Details:
_mi_prim_out_stderr()only treatsINVALID_HANDLE_VALUEas invalid, so aNULLhandle reachesWriteFile(NULL, ...)instead of the fallback path and diagnostics are lost. - Evidence:
src/prim/windows/prim.c:593-616
Issue 34: Weak-seed fallback uses undefined uint32_t* stores
- Severity: Low
- Location:
src/random.c:172-190 - Details: The fallback fills
uint8_t key[32]through((uint32_t*)key)[i], which assumes alignment and violates C's type rules for the object. - Evidence:
src/random.c:172-190
Issue 37: TLS key version is truncated to half a word
- Severity: Low
- Location:
src/threadlocal.c:39-60 - Details: Key encoding stores the version in only the upper half of the word while the global version counter advances as a full
size_t, so very old stale keys can eventually alias reused slots. - Evidence:
src/threadlocal.c:39-60;src/threadlocal.c:120-126
Issue 38: Function pointer is passed through void*
- Severity: Low
- Location:
src/theap.c:675-688 - Details:
mi_theap_visit_areas()casts a function pointer throughvoid*and back, which is non-portable undefined behavior on architectures with distinct code/data pointer representations. - Evidence:
src/theap.c:675-688
None / Informational
Issue 10: Managed-arena allocation bypasses commit_fun
- Severity: None
- Location:
src/arena.c:236-253 - Details:
mi_manage_memory()stores the user commit callback, butmi_arena_try_alloc_at()commits with_mi_os_commit_ex()instead of themi_arena_commit()helper, so managed-arena commit callbacks can be skipped. - Evidence:
src/arena.c:236-253;src/arena.c:1656-1664
Issue 14: arena_pages_lock is never destroyed on heap teardown
- Severity: None
- Location:
src/heap.c:167-194 - Details:
mi_heap_new_in_arena()initializesarena_pages_lock, butmi_heap_free()destroys only the other heap locks before freeing the heap object. - Evidence:
src/heap.c:119-121,167-194,208-212
Issue 30: ETW enable-state updates race with alloc/free checks
- Severity: None
- Location:
src/prim/windows/etw.h:381-390 - Details: Generated ETW code updates provider enable bits with ordinary stores and RMW operations while hot-path event checks read them concurrently; this breaks tracing-state synchronization but does not directly affect allocator integrity.
- Evidence:
src/prim/windows/etw.h:381-390,396-402,649-655
Issue 35: mi_subproc_stats_get clears the output header
- Severity: None
- Location:
src/stats.c:606-612 - Details: The function validates
stats->sizeandstats->version, zeroes the whole buffer, and never restores those header fields before returning success. - Evidence:
src/stats.c:606-612;src/stats.c:119-133
Issue 36: Subprocess JSON export drops per-heap statistics
- Severity: None
- Location:
src/stats.c:790-795 - Details:
mi_subproc_stats_get_json()aggregates into a localstatsbuffer but serializes&subproc->statsinstead, omitting live heap data. - Evidence:
src/stats.c:723-779;src/stats.c:790-795
- 主要语言
- C
- 星标
- 13.6k
- 派生
- 1.2k
- 平均合并
- 18 小时 12 分钟
- 30 天内合并 PR
- 20
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/mimalloc 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
Building mimalloc with `-Wundef` compiler flag logs many warnings on undefined macros可能已有人在做 @vstinner 于 1 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 64/100
microsoft/mimalloc#1506 · 5 条评论 ·
维护者通常 1 天内回复
-
stale
难度 2/5 1-3 小时 新手友好度 74/100
microsoft/mimalloc#1113 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
microsoft/mimalloc#886 · 4 条评论 · 1 个 reaction ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 64/100
microsoft/mimalloc#368 · 1 条评论 ·
维护者通常 1 天内回复
查看 microsoft/mimalloc 的全部 Issue
相似的 Issue
-
needs triage
难度 2/5 1-3 小时 新手友好度 70/100
389ds/389-ds-base#8157 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
coolsnowwolf/lede#14305 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
Needs-Triage
难度 2/5 1-3 小时 新手友好度 66/100
维护者通常 2 天内回复