mimalloc3 wasi target fails to compile

未关闭
#1,134 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
52/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
c, wasm

调研方向

使用 issue 中显示的 WASI SDK 命令重现失败,然后检查 src/prim/wasi/prim.c 的第 92 行和第 101 行,以及 include/mimalloc/internal.h 中的 helper 声明。确认 WASI target 能够成功构建,并且 alignment 调用使用了已声明的 helper。

由索引模型根据 Issue 内容生成。

描述

I get the compilation errors when I try to build mimalloc3 using wasi target.

git clone --branch v3.1.5 https://github.com/microsoft/mimalloc.git
~/w/h/s/h/t/mimalloc ((v3.1.5)) [1]> ~/workspace/build/wasi-sdk-23.0-x86_64-linux/bin/clang src/static.c -I include/ -I src/ --sysroot ~/workspace/build/wasi-sdk-23.0-x86_64-linux/share/wasi-sysroot/
In file included from src/static.c:38:
In file included from src/prim/prim.c:19:
src/prim/wasi/prim.c:92:33: error: call to undeclared function 'mi_align_up_ptr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
   92 |         void* aligned_current = mi_align_up_ptr(current, try_alignment);  // and align from there to minimize wasted space
      |                                 ^
src/prim/wasi/prim.c:92:33: note: did you mean '_mi_align_up_ptr'?
include/mimalloc/internal.h:441:24: note: '_mi_align_up_ptr' declared here
  441 | static inline uint8_t* _mi_align_up_ptr(void* p, size_t alignment) {
      |                        ^
In file included from src/static.c:38:
In file included from src/prim/prim.c:19:
src/prim/wasi/prim.c:92:15: error: incompatible integer to pointer conversion initializing 'void *' with an expression of type 'int' [-Wint-conversion]
   92 |         void* aligned_current = mi_align_up_ptr(current, try_alignment);  // and align from there to minimize wasted space
      |               ^                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/prim/wasi/prim.c:101:11: error: call to undeclared function 'mi_align_up_ptr'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
  101 |       p = mi_align_up_ptr(base, try_alignment);
      |           ^
src/prim/wasi/prim.c:101:9: error: incompatible integer to pointer conversion assigning to 'void *' from 'int' [-Wint-conversion]
  101 |       p = mi_align_up_ptr(base, try_alignment);
      |         ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
4 errors generated.

I'm able to get rid of those by s/mi_align_up_ptr/_mi_align_up_ptr. I'm happy to create PR if that's what needed to fix it.

主要语言
C
星标
13.6k
派生
1.2k
平均合并
18 小时 12 分钟
30 天内合并 PR
20

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

microsoft/mimalloc 的其他 Issue

查看 microsoft/mimalloc 的全部 Issue

相似的 Issue

更多 C Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。