[Bug]: Vertical Slider still logs the deprecated 'slider-vertical' warning in Chromium 132+
维护者通常 1 天内回复
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 74/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- css, react, typescript
- 领域
- frontend
调研方向
从 Slider 样式文件 useSliderStyles.styles.ts 开始,检查 issue 中描述的 vertical 样式和 @supports 分支。移除已弃用的回退方案,或在该分支中使用标准化声明。然后验证垂直 Slider 能够在没有 Chromium 警告的情况下渲染,并保持垂直布局。
由索引模型根据 Issue 内容生成。
描述
Component
Slider
Package version
@fluentui/[email protected] (@fluentui/[email protected], the current release)
React version
19.3.1
Environment
System:
OS: Windows 11 10.0.26300
CPU: (24) x64 AMD Ryzen 9 7900X 12-Core Processor
Memory: 13.83 GB / 31.16 GB
Browsers:
Chrome: 155.0.8059.85
Edge: Chromium (4.1)
npmPackages:
@fluentui/react-components: 9.74.10 => 9.74.10
@fluentui/react-slider: 9.6.7 => 9.6.7
react: 19.3.1 => 19.3.1
react-dom: 19.3.1 => 19.3.1
@types/react: 19.3.0 => 19.3.0
@types/react-dom: 19.3.0 => 19.3.0
Current Behavior
Rendering Slider vertical from the current release still logs the deprecation warning in every app that mounts a vertical slider:
[Deprecation] The keyword 'slider-vertical' specified to an 'appearance' property is not standardized. It will be removed in the future. Use <input type=range style="writing-mode: vertical-lr; direction: rtl"> instead.
useSliderStyles.styles.ts emits the value in the unsupported branch of a sideways-lr probe:
'@supports (writing-mode: sideways-lr)': { writingMode: 'vertical-lr', direction: 'rtl' },
'@supports not (writing-mode: sideways-lr)': { WebkitAppearance: 'slider-vertical' },
#34022 added that probe to fix #33944, which is correct for browsers without sideways-lr. Chromium 132 added sideways-lr, so in current Chromium the second block never matches and the vertical slider is styled by the first branch. The declaration is dead, but Chromium still reports it while parsing the CSS: the warning fires even though the @supports condition is false, and even when the selector matches no element.
Measured on Chrome 155.0.8059.85 (Windows 11):
CSS.supports('writing-mode', 'sideways-lr')istrue, so the fallback block does not apply.@supports not (writing-mode: sideways-lr) { .a { -webkit-appearance: slider-vertical } }with no matching element still logs the deprecation.- The same rule injected at runtime with
CSSStyleSheet.insertRule, which is how Griffel inserts it, logs the warning too. .b { writing-mode: vertical-lr; direction: rtl }renders a vertical range input (16 x 129 px for a default input) with no warning.
This is a follow-up to #33944 and #34022: the case where the fallback actually applied is fixed, and the remaining warning only appears once a browser supports sideways-lr.
Expected Behavior
The vertical Slider should render without logging the deprecation warning. The warning's own recommendation is writing-mode: vertical-lr; direction: rtl, and vertically oriented form controls have supported it since Chrome 124, Firefox 120 and Safari 17.4, so the sideways-lr probe no longer needs a deprecated fallback:
vertical: {
height: '100%',
width: `var(${sliderThumbSizeVar})`,
writingMode: 'vertical-lr',
direction: 'rtl',
},
Dropping the @supports split is behaviour-identical in every browser that supports sideways-lr (Chromium 132+, Firefox 43+, Safari 18.4+), because those browsers already take the first branch. Browsers that support vertical form controls but not sideways-lr (Chrome 124-131, Safari 17.4-18.3) currently get the deprecated native appearance and would get the standardized one instead. Only browsers older than Chrome 124, Firefox 120 and Safari 17.4 lose the legacy native vertical appearance, which the removal of the keyword forces eventually anyway.
If a fallback branch should stay, mirroring the standardized declarations into the @supports not (writing-mode: sideways-lr) block also silences the warning, because the deprecated value is the only thing Chromium reports.
Version data is from MDN browser-compat-data: writing-mode: sideways-lr and the vertically oriented form controls note in css/properties/writing-mode.json.
Reproduction
https://gist.github.com/jakesalvesen/0a6871b1c7c59da40fd0cfbc77d75ad7 - a standalone HTML page that renders the exact rule @fluentui/react-slider emits next to the recommended declarations, and prints the support and layout measurements on the page.
Steps to reproduce
- Render
Slider verticalfrom@fluentui/react-componentsin Chrome 132 or newer, for example<div style={{ height: 200 }}><Slider vertical /></div>. - Open DevTools and load the page: the deprecation warning for
slider-verticalis logged once, even though the vertical slider is rendered bywriting-mode: vertical-lr. - Save the attached gist page and open it in the same browser. Case A is the rule the package emits, Case B is the recommended declarations. DevTools logs the warning for Case A only, and the page prints
CSS.supports('writing-mode', 'sideways-lr')astrue, so Case A never applies. - Delete the
-webkit-appearance: slider-verticaldeclaration (or move the standardized declarations into the unsupported branch): the warning is gone and the vertical slider is unchanged.
Are you reporting an Accessibility issue?
no
Suggested severity
Low - Has or doesn't need a workaround
Products/sites affected
Internal Power Apps code app that renders vertical Sliders in a filter panel
Are you willing to submit a PR to fix?
yes
Validations
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- The provided reproduction is a minimal reproducible example of the bug.
- 主要语言
- TypeScript
- 星标
- 20.3k
- 派生
- 2.9k
- 平均合并
- 2 天 6 小时
- 30 天内合并 PR
- 72
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/fluentui 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
维护者通常 1 天内回复
-
@fluentui/web-components: fluent-menu-list loses its arrow keys after it is moved in the DOM (Firefox, Safari)可能已有人在做 @asxxb 于 9 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
[Feature]: export getHashCode for Avatar from avatar.ts for Fluentv8 PersonaInitialsColor / PersonaCoin support可能已有人在做 @ValentinaKozlova 于 22 天前认领。 未关闭Component: Avatar Fluent UI react-components (v9) From Shield Needs: Backlog review Type: Feature
难度 2/5 1-3 小时 新手友好度 78/100
microsoft/fluentui#36802 · 已指派 1 人 ·
维护者通常 1 天内回复
-
[Bug]: WeeklyDayPicker showing incorrect week number when navigating to different weeks可能已有人在做 @Sanjays2402 于 40 天前认领。 未关闭Component: CalendarDayGrid Component: WeeklyDayPicker Fluent UI react (v8) Type: Bug :bug:
难度 2/5 1-3 小时 新手友好度 82/100
microsoft/fluentui#36721 · 2 条评论 ·
维护者通常 1 天内回复
查看 microsoft/fluentui 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
chaitin/MonkeyCode#1437 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 72/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 69/100
carbon-design-system/carbon-ai-chat#2615 ·
维护者通常 1 天内回复
-
e2e-failure ready-to-code
难度 2/5 1-3 小时 新手友好度 76/100
redhat-developer/rhdh-plugin-export-overlays#4486 · 1 条评论 ·
维护者通常 1 天内回复
-
[Bug]: fileUploadMatrix.test.ts URL case does a real DNS lookup and fails offline可能已有人在做 @r2jaff 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
ComposioHQ/composio#5054 ·
维护者通常 1 天内回复