Proposal: remove requirement for exact instruction count for disassemble response
还没有人认领这个 Issue。
评估
调研方向
先从 issue 中引用的反汇编请求定义和 instructionCount 规范开始，然后检查 VS Code 反汇编视图如何解释返回的地址。定义可用指令较少时的预期响应，并明确地址规则；当协议规范对客户端和调试适配器双方都没有歧义时，即视为完成。
由索引模型根据 Issue 内容生成。
描述
The spec requires debug adapters to return exactly the number of instructions requested.
/**
* Number of instructions to disassemble starting at the specified location
* and offset.
* An adapter must return exactly this number of instructions - any
* unavailable instructions should be replaced with an implementation-defined
* 'invalid instruction' value.
*/
instructionCount: number;
This presents an issue when there are not enough instructions available. The DA is then required to return an "implementation-defined" invalid instruction. It is unclear how those instructions will be used, and why they are even necessary to return. Scrolling through invalid instructions does not provide any additional information to users.
Also what the addresses should be for the invalid instructions is not defined in the spec so it is unclear how the editor can interpret them. For example, the VS Code implementation of a disassembly view will attempt to do a binary search using the addresses, which requires that the invalid instructions obey certain rules to implement this. This may also result in having to return negative addresses which also does not really make sense for an instruction.
Removing the requirement to return exactly the number of requested instructions would better define the expected disassembled instructions for both the client and server.
- 主要语言
- HTML
- 星标
- 1.8k
- 派生
- 173
- 平均合并
- 7 天 7 小时
- 30 天内合并 PR
- 2
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
microsoft/debug-adapter-protocol 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 5/5 一周以上 新手友好度 35/100
microsoft/debug-adapter-protocol#633 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 42/100
-
难度 5/5 一周以上 新手友好度 35/100
microsoft/debug-adapter-protocol#599 · 8 个 reaction ·
-
under-discussion
难度 2/5 1-3 小时 新手友好度 48/100
microsoft/debug-adapter-protocol#596 · 9 条评论 ·
查看 microsoft/debug-adapter-protocol 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 90/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
jessepollak/home#1627 ·
维护者通常 1 天内回复
-
enhancement status: needs triage
难度 2/5 1-3 小时 新手友好度 88/100
mastra-ai/mastra#25508 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
canonical/testflinger#1346 · 1 条评论 ·
维护者通常 2 天内回复
-
onedrive: ChangeNotify drops the delta token after one failed poll and stops notifying until remount未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 3 天内回复