Crash in getLocalModuleSpecifier when formatting a type: normalizeSlashes receives undefined (regression in 6.0)
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript, nodejs, typescript
调研方向
The crash occurs in getLocalModuleSpecifier when normalizeSlashes receives undefined. Start by examining the TypeScript source at src/compiler/moduleSpecifiers.ts and src/compiler/utilities.ts around the normalizeSlashes call. Reproduce the issue with the provided ESLint setup to see the stack trace. Look for where the importing file's path becomes undefined during the second parse after a fix is applied. Check how SourceFile paths are handled in the language service or program reuse scenarios.
由索引模型根据 Issue 内容生成。
描述
🔎 Search Terms
normalizeSlashes, getLocalModuleSpecifier, computeModuleSpecifiers, getSpecifierForModuleSymbol, symbolToNode, "Cannot read properties of undefined (reading 'includes')"
🕗 Version & Regression Information
Crashes on typescript@6.0.3. The identical project on typescript@5.9.3 does not crash — nothing else changed, only the typescript dependency. So this is a regression between 5.9 and 6.0.
⏯ Playground Link
Not reproducible in the playground: it needs a Program created from a tsconfig with a package in node_modules, and a second parse of modified file text.
💻 Code
Four files. npm install, then two commands.
package.json
{
"name": "ts6-fix-crash-repro",
"private": true,
"type": "module",
"devDependencies": {
"eslint": "10.10.0",
"typescript": "6.0.3",
"typescript-eslint": "8.70.1",
"vitest": "5.0.0"
}
}
tsconfig.json
{
"compilerOptions": {
"target": "ES2022",
"module": "NodeNext",
"moduleResolution": "NodeNext",
"strict": true,
"noEmit": true
},
"include": ["src"]
}
eslint.config.mjs
import tseslint from 'typescript-eslint';
export default tseslint.config({
files: ['src/**/*.ts'],
extends: [...tseslint.configs.recommendedTypeChecked],
languageOptions: {
parserOptions: { project: './tsconfig.json', tsconfigRootDir: import.meta.dirname },
},
});
src/index.ts
/* eslint-disable @typescript-eslint/no-explicit-any */
import { vi } from 'vitest';
export const f = vi.fn();
Run:
npx eslint src # exit 0 — one warning, the unused disable directive
npx eslint src --fix-dry-run # exit 2 — crash
The eslint-disable comment on line 1 is deliberately unused. It is the only fixable thing in the project, so it is what makes the second command apply a fix and re-parse the file. Delete that line and --fix-dry-run exits cleanly.
🙁 Actual behavior
TypeError: Cannot read properties of undefined (reading 'includes')
Occurred while linting .../src/index.ts:4
Rule: "@typescript-eslint/no-unsafe-assignment"
at normalizeSlashes (typescript/lib/typescript.js:8853:15)
at getNormalizedAbsolutePath (typescript/lib/typescript.js:8899:12)
at getLocalModuleSpecifier (typescript/lib/typescript.js:50210:25)
at computeModuleSpecifiers (typescript/lib/typescript.js:50155:19)
at getModuleSpecifiersWithCacheInfo (typescript/lib/typescript.js:50089:18)
at getModuleSpecifiers (typescript/lib/typescript.js:50056:10)
at getSpecifierForModuleSymbol (typescript/lib/typescript.js:57728:27)
at createExpressionFromSymbolChain (typescript/lib/typescript.js:57987:29)
at symbolToExpression (typescript/lib/typescript.js:57974:14)
at symbolToNode (typescript/lib/typescript.js:55769:14)
normalizeSlashes is called with undefined. The named rule is incidental — it is whichever type-aware rule reaches the file first. Disabling no-unsafe-assignment moves the crash to no-misused-promises, and disabling that moves it to no-unnecessary-type-assertion.
🙂 Expected behavior
getLocalModuleSpecifier should not dereference an absent path on the importing file, or the caller should not reach it with one. Formatting a type should not throw.
Additional information
Conditions, each verified by changing one thing and re-running:
| change | result |
|---|---|
typescript@6.0.3 |
crash |
typescript@5.9.3, everything else identical |
no crash |
parserOptions.project |
crash |
parserOptions.projectService: true instead |
no crash |
TSESTREE_SINGLE_RUN=false in the environment |
no crash |
remove the unused eslint-disable line (so no fix is applied) |
no crash |
recommendedTypeChecked or strictTypeChecked |
crash either way |
npm or pnpm for the install |
crash either way |
A fix being applied is necessary: without one there is no second parse and no crash.
I could not reduce this below the ESLint harness. Calling checker.typeToString(type, enclosingDeclaration, TypeFormatFlags.UseFullyQualifiedType) directly does not reproduce it, including when enclosingDeclaration is a SourceFile from a different Program, or one built with ts.createSourceFile whose path I removed — those all format fine. So the pathless importing file appears to arise from something more specific than a detached SourceFile, and I have not identified what.
Related: typescript-eslint#12749 reported the same stack from a different trigger (CI=true, so the same single-run Program inference that TSESTREE_SINGLE_RUN=false disables above). It was closed as external on the grounds that the stack is inside TypeScript, with a request to file here and to include a reproduction. This is that reproduction.
Environment: macOS 27.0 arm64, Node v26.8.1.
- 主要语言
- Go
- 星标
- 111k
- 派生
- 14.4k
- 平均合并
- 2 天 3 小时
- 30 天内合并 PR
- 125
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/TypeScript 的其他 Issue
-
Possible Improvement
难度 2/5 1-3 小时 新手友好度 78/100
microsoft/TypeScript#64278 · 1 条评论 · 1 个 reaction ·
-
Docs
难度 2/5 1-3 小时 新手友好度 70/100
microsoft/TypeScript#64118 · 1 条评论 ·
-
难度 1/5 1 小时以内 新手友好度 88/100
microsoft/TypeScript#64094 ·
-
Docs
难度 2/5 1-3 小时 新手友好度 76/100
microsoft/TypeScript#63959 · 5 条评论 ·
-
Domain: lib.d.ts Help Wanted
难度 1/5 1 小时以内 新手友好度 91/100
microsoft/TypeScript#63722 · 4 条评论 · 1 个 reaction ·
查看 microsoft/TypeScript 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100
-
acceptance-tests phase-coding schema-coverage testing triaged
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 75/100