BUG: MathObfuscation, NegationTrap, SelectiveText and Zalgo converter identifiers ignore settings that change output
维护者通常 2 天内回复
评估
调研方向
Read the identifier implementations for MathObfuscationConverter, NegationTrapConverter, SelectiveTextConverter, and ZalgoConverter; compare them with seeded converters such as EmojiConverter. Use the reproduction pairs and ConverterRegistry registration shown in the issue to check the behavior. Done means differently configured instances have different identifiers and both NegationTrapConverter instances register successfully.
由索引模型根据 Issue 内容生成。
描述
Describe the bug
Four text converters leave settings that change their output out of their identifiers, so differently configured instances share one hash:
MathObfuscationConverter:hintandsuffix(onlymin_nandmax_nare included).NegationTrapConverter:wrong_valueandtrap_template. It does not override_build_identifier()at all, so its identifier only holds the supported input and output types.SelectiveTextConverter:word_separator, which word-level strategies split and rejoin on.ZalgoConverter:seed. Other seeded converters (EmojiConverter,CharSwapConverter,AskToDecodeConverter,RandomCapitalLettersConverter, ...) includeseed.
Because the default registry name comes from that hash, registering a second configuration without a custom name raises a duplicate-name error, and memory and analytics cannot tell the configurations apart. This is the same problem as #3242 and #3244, for these text converters.
Steps/Code to Reproduce
from pyrit.converter import (
Base64Converter,
MathObfuscationConverter,
NegationTrapConverter,
SelectiveTextConverter,
ZalgoConverter,
)
from pyrit.converter.text_selection_strategy import WordPositionSelectionStrategy
from pyrit.registry import ConverterRegistry
words = WordPositionSelectionStrategy(start_proportion=0, end_proportion=0.5)
pairs = [
(MathObfuscationConverter(hint="a"), MathObfuscationConverter(hint="")),
(MathObfuscationConverter(suffix="x"), MathObfuscationConverter(suffix="")),
(NegationTrapConverter(wrong_value="1234"), NegationTrapConverter(wrong_value="hunter2")),
(
NegationTrapConverter(trap_template="A {prompt} {wrong_value}"),
NegationTrapConverter(trap_template="B {prompt} {wrong_value}"),
),
(
SelectiveTextConverter(sub_converter=Base64Converter(), selection_strategy=words),
SelectiveTextConverter(sub_converter=Base64Converter(), selection_strategy=words, word_separator=","),
),
(ZalgoConverter(seed=1), ZalgoConverter(seed=2)),
]
for first, second in pairs:
print(first.get_identifier().unique_name, second.get_identifier().unique_name)
registry = ConverterRegistry()
registry.instances.register(NegationTrapConverter(wrong_value="1234"))
registry.instances.register(NegationTrapConverter(wrong_value="hunter2"))
Expected Results
Each pair has two different identifiers, and both NegationTrapConverter instances register.
Actual Results
MathObfuscationConverter::81c6f15b MathObfuscationConverter::81c6f15b
MathObfuscationConverter::81c6f15b MathObfuscationConverter::81c6f15b
NegationTrapConverter::89a3d225 NegationTrapConverter::89a3d225
NegationTrapConverter::89a3d225 NegationTrapConverter::89a3d225
SelectiveTextConverter::91a088c0 SelectiveTextConverter::91a088c0
ZalgoConverter::78d075f9 ZalgoConverter::78d075f9
ValueError: Instance 'NegationTrapConverter::89a3d225' already exists
Screenshots
N/A
Versions
- OS: Windows 11
- Python version: 3.11.9
- PyRIT version: installed from main (5b594e00) in editable mode
- 主要语言
- Python
- 星标
- 4.6k
- 派生
- 962
- 平均合并
- 2 天 16 小时
- 30 天内合并 PR
- 354
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
microsoft/PyRIT 的其他 Issue
-
BUG: label queries only return the final conversation of an attack可能已有人在做 @u7k4rs6 于 5 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 85/100
microsoft/PyRIT#3095 · 4 条评论 · 已指派 1 人 ·
维护者通常 2 天内回复
-
难度 3/5 1-2 天 新手友好度 72/100
microsoft/PyRIT#3325 · 1 条评论 ·
维护者通常 2 天内回复
-
Detection coverage gaps: 47 missed payload classes across 9 output scorers可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 4/5 3-5 天 新手友好度 53/100
维护者通常 2 天内回复
-
难度 4/5 3-5 天 新手友好度 46/100
维护者通常 2 天内回复
-
BUG: Tone, Tense, Translation, Noise, ScientificTranslation and Variation converter identifiers ignore a custom prompt_template可能已有人在做 @ShivamSharma43 今天认领。 未关闭
难度 3/5 1-2 天 新手友好度 20/100
维护者通常 2 天内回复
相似的 Issue
-
debt
难度 2/5 1-3 小时 新手友好度 68/100
microsoft/vscode-flake8#601 ·
维护者通常 1 天内回复
-
nonews refactor
难度 2/5 1-3 小时 新手友好度 75/100
Uninett/nav#4255 · 1 条评论 · 1 个 reaction ·
维护者通常 3 天内回复
-
namespace operations
难度 1/5 1 小时以内 新手友好度 70/100
EclipseFdn/open-vsx.org#14421 ·
维护者通常 1 天内回复
-
untriaged
难度 2/5 1-3 小时 新手友好度 78/100
ubuntu/ubuntu-project-docs#850 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 83/100
维护者通常 1 天内回复