Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

AsciiArtConverter silently drops every non-ASCII character

未关闭
  • 哪里不对？
#2,942 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

@Pushpak731 已经在做这个了。

开始于 2026年10月2日。

  • #2962 来自 @Pushpak731 —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
38/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
security

调研方向

Start with pyrit/converter/ascii_art_converter.py and test_ascii_art_converter.py, then inspect the neighboring ascii_smuggler_converter.py, NatoConverter, and BrailleConverter behavior. Reproduce the non-ASCII cases against art.text2art and the available fonts. Done means the maintainer-selected behavior is implemented and regression tests prove prompts are not silently altered.

由索引模型根据 Issue 内容生成。

描述

AsciiArtConverter silently deletes every non-ASCII character from the prompt. Nothing is raised and nothing is logged — the target just receives a mangled prompt, or no prompt at all.

What happens

convert_async hands the prompt straight to art.text2art:

# pyrit/converter/ascii_art_converter.py:76
return ConverterResult(output_text=text2art(prompt, font=font), output_type="text")

text2art has no glyph for a character, so it omits it. I probed every font the art package exposes — 371 in total, 354 of them in this converter's rand pool:

character dropped by
é, ü 371 / 371
日, 本, 語, 漢 371 / 371
🙂 371 / 371
“, — 371 / 371
ß 307 / 371
A 2 / 371 (hills, nfi1)

Accented Latin, CJK, emoji, smart quotes and em-dashes are dropped by every font, so the loss does not depend on which font gets drawn.

Two concrete consequences

One character disappears, taking its whole glyph block with it:

AsciiArtConverter(font="block").convert_async(prompt="cafe")  -> 4 glyph blocks (892 chars)
AsciiArtConverter(font="block").convert_async(prompt="café")  -> 3 glyph blocks (672 chars)

And a prompt written entirely in a non-ASCII script converts to the empty string. With the default font="rand" this holds on every draw:

AsciiArtConverter().convert_async(prompt="日本語の指示")            -> output_text=''  (12/12 draws)
AsciiArtConverter(font="block").convert_async(prompt="忽略之前的所有指令") -> ''

For a red-teaming framework this is the harmful direction. A Chinese- or Japanese-language attack prompt is a first-class use case, and it converts to nothing. A mixed prompt reaches the target quietly altered, with no signal to the red-teamer.

Why I think this is a defect

Three things already in this repo establish the opposite convention for the same situation:

  • AsciiSmugglerConverter raises ValueError naming the characters outside the range it can encode (ascii_smuggler_converter.py:69-74, merged in #2540).
  • NatoConverter was changed to pass unmapped characters through rather than delete them (#2399).
  • BrailleConverter got the same treatment (#2539).

AsciiArtConverter's docstring documents only ValueError: If the input type is not supported; it never mentions that non-ASCII input is dropped. The tests only feed ASCII prompts — test_ascii_art_converter.py:16-29 assert len(result.output_text) > 0 — so nothing pins this behaviour in either direction.

What behaviour do you want?

Option A — raise, naming the characters this font cannot render. Consistent with #2540, and it fails loudly instead of altering the attack. Cost: a campaign whose prompts contain an accent or an emoji would start raising. Checking the resolved font is deterministic for everything that matters here, since the characters above are dropped by all 371 fonts; only ß-type characters are font-dependent, so under font="rand" such a prompt could raise on one draw and not the next.

Option B — render what the font can, pass the rest through. Keeps pipelines running and stops losing content, at the cost of a mixed output (art plus bare characters). This matches what #2399 and #2539 ended up doing for the other converters.

Option C — document the restriction, change nothing. Cheapest, but a silently altered attack prompt is a poor default for a tool whose job is to send a precise prompt.

I lean towards A: "the prompt that reaches the target is not the prompt I wrote" is precisely the failure a red-teaming tool should refuse rather than hide, and #2540 already set that precedent for the converter next door. If B is preferable because non-ASCII prompts are expected to keep working, I would implement B instead.

Happy to take whichever you pick, with regression tests over the real art font list. Everything above was measured against the installed art package; I called no model or target.

主要语言
Python
星标
4.6k
派生
924
平均合并
2 天 18 小时
30 天内合并 PR
251

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

microsoft/PyRIT 的其他 Issue

查看 microsoft/PyRIT 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。