fix(source-control): pull-request ready pushes from the session cwd, not the PR worktree
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 半天
- 新手友好度
- 68/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- git, github, shell
调研方向
Start from the source-control pull-request ready skill and the push step that calls push-branch.sh. Trace how the cwd vs PR worktree is chosen, then pass an explicit worktree, branch, or PR-derived refspec so a different session cwd cannot push the wrong branch or print up-to-date. Add a test that runs the script from worktree A for a PR on worktree B and asserts B is pushed or the script exits non-zero.
由索引模型根据 Issue 内容生成。
描述
Problem
On 2026-10-04 a subagent ran /source-control:pull-request ready 6275 against the PR's worktree (/home/kyle/worktrees/melodic-software-claude-code-plugins-fix-wizard-write-env). The skill's push step (push-branch.sh) ran from the session's working directory, a different worktree, printed "Everything up-to-date", and pushed nothing. The merge-base commit only reached the PR because the agent noticed and pushed from the PR's worktree by hand.
A caller that trusts the script's success would flip a PR ready whose pushed head lacks the base merge, so CI and review run on the old head.
Expected
The push step pushes the branch of the PR being readied, from that PR's worktree (or with an explicit worktree path or refspec), and fails, rather than reporting "up-to-date", when the session's working directory is not on that branch.
Acceptance
push-branch.shtakes the target worktree or branch explicitly, or resolves it from the PR number, and never pushes the cwd's branch for a different PR.- A test runs the script from worktree A for a PR on worktree B and asserts B's branch is pushed, or the script exits non-zero.
- 主要语言
- Shell
- 星标
- 22
- 派生
- 2
- 平均合并
- 5 小时 11 分钟
- 30 天内合并 PR
- 838
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
melodic-software/claude-code-plugins 的其他 Issue
-
good first issue needs-triage priority: medium
难度 2/5 1-3 小时 新手友好度 72/100
melodic-software/claude-code-plugins#6631 · 1 条评论 ·
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 78/100
melodic-software/claude-code-plugins#6547 ·
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 76/100
melodic-software/claude-code-plugins#6535 ·
维护者通常 1 天内回复
-
test_comment_census.py: SccArgv flag-shaped-filename test errors on Windows (#!/bin/sh scc shim)未关闭good first issue needs-triage priority: low
难度 2/5 1-3 小时 新手友好度 72/100
melodic-software/claude-code-plugins#6532 · 1 条评论 ·
维护者通常 1 天内回复
-
good first issue needs-triage priority: low
难度 2/5 1-3 小时 新手友好度 72/100
melodic-software/claude-code-plugins#6390 · 1 条评论 ·
维护者通常 1 天内回复
查看 melodic-software/claude-code-plugins 的全部 Issue
相似的 Issue
-
`helios / deploy`: switch zone wait in `deploy.sh` has almost no headroom over healthy startup times可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭Test Flake
难度 2/5 1-3 小时 新手友好度 74/100
oxidecomputer/omicron#11453 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
-
data only (no code) enhancement good first issue
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 65/100
developmentseed/eoAPI#236 ·