Simplify the setup-apply.mjs verification plugin code

未关闭 适合新手
  • 哪里不对？
#15,008 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
64/100
Issue 类型
重构
描述清晰度
描述清楚
活跃度
活跃
技术栈
javascript, node.js
领域
tooling

调研方向

从 plugins/verification/skills/setup/scripts/setup-apply.mjs 开始，检查其中的辅助函数、抽象和效率，同时保留列出的接口和行为。运行与此脚本相关的检查，并比较输出、退出代码、写入的文件和打印的消息；完成的标准是文件更简单、更清晰，且这些结果保持不变。

由索引模型根据 Issue 内容生成。

描述

status: ready

Agent Brief

Type: Task
Summary: Simplify these 1 files without changing their behavior (part of the /simplify epic).

Current behavior:
The files below work as they do on main. Their code changes; what they do does not.

Desired behavior:
Review the files through /simplify's four checks (reuse of existing helpers, simplification, efficiency, right level of abstraction), using subagents if useful, and apply the fixes. The files end up shorter and clearer, and whatever runs them gets the same results.

Files:

  • plugins/verification/skills/setup/scripts/setup-apply.mjs

Key interfaces:

  • Outputs, exit codes, written files and printed messages of these files: unchanged.
  • Command-line flags, exported names and anything another file calls: unchanged.

Acceptance criteria:

  • Behavior is unchanged: same outputs, exit codes, written files, printed text, command-line flags and exported names; no listed file renamed, moved or deleted.
  • The diff edits only the listed files, the lines of a test that assert on them when the change breaks that assertion, and changelog fragments.
  • The pull request stays within 400 changed lines and 15 hand-edited files (generated shared copies and changelog fragments not counted); anything beyond goes under ## Follow-ups in the pull request body.
  • ci-status is green.
  • Each touched plugin (verification) has a fragment from scripts/new-changelog-fragment.sh <plugin> patch whose body is ### Changed and the line "Internal simplification, no behavior change."

Out of scope:

  • Moving code between files or deduping across them: the sub-epic's restructuring pass does that after these chunks merge.
  • Tests beyond the asserted lines a change breaks, eval cases, fixtures, and skill and agent text.
  • Files listed in other chunks.
  • These eval and fixture files, which read the listed files' names, flags or printed text; the behavior rule keeps them accurate:
    • plugins/verification/evals/setup-apply-placement-not-configurable/case.yaml
    • plugins/verification/evals/setup-apply-refuses-thorough/case.yaml
    • plugins/verification/evals/setup-apply-refuses-zero-workers/case.yaml
    • plugins/verification/evals/setup-apply-strict-shows-diff/case.yaml
    • plugins/verification/evals/setup-apply-writes-live-workers/case.yaml
    • plugins/verification/evals/setup-check-memory-root/case.yaml
主要语言
Shell
星标
22
派生
2
平均合并
1 小时 5 分钟
30 天内合并 PR
969

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

melodic-software/claude-code-plugins 的其他 Issue

查看 melodic-software/claude-code-plugins 的全部 Issue

相似的 Issue

更多 Shell/Bash Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。