Objects do not propagate across parfor, need save/load methods
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
调研方向
Start with opentelemetry.trace.Tracer/startSpan, especially the reported failure at line 125, and review how the global singleton proxymanager handles proxies across parfor workers. Investigate the custom save/load methods requested for objects and their C++ counterparts. Done means the tracer and related objects propagate through the shown parfor example without the Unknown proxy ID 3 error.
由索引模型根据 Issue 内容生成。
描述
The following code would fail:
tr = opentelemetry.trace.getTracer("parfor_example");
sp = startSpan(tr, "main function");
...
parfor i = 1:8
% start a span for this iteration, using the tracer “tr” from main function
sp_i = startSpan(tr, "Iteration" + i);
...
end
Since tr is used both in and outside of the parfor block, parfor would copy and send it to the workers. Running this code would result in this error:
Error using . (line 63)
Unknown proxy ID 3
Error in opentelemetry.trace.Tracer/startSpan (line 125)
id = obj.Proxy.startSpan(spname, contextid, spankind, starttime, ...
This is because the global singleton proxymanager is not copied. In the workers, the proxies only exist in MATLAB but not in C++.
To make objects correctly propagate through to parfor blocks, they need to implement custom save/load methods which should also save/load their C++ counterparts.
- 主要语言
- MATLAB
- 星标
- 19
- 派生
- 4
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
mathworks/OpenTelemetry-MATLAB 的其他 Issue
-
documentation
难度 3/5 1-2 天 新手友好度 48/100
-
documentation
mathworks/OpenTelemetry-MATLAB#248 · 已指派 1 人 ·
-
test
难度 4/5 3-5 天 新手友好度 45/100
-
otel-cpp changes
难度 3/5 1-2 天 新手友好度 42/100
-
enhancement
mathworks/OpenTelemetry-MATLAB#242 · 1 条评论 · 已指派 1 人 ·
查看 mathworks/OpenTelemetry-MATLAB 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 1/5 1 小时以内 新手友好度 88/100
-
难度 1/5 1 小时以内 新手友好度 75/100
-
Documentation Good first issue
难度 2/5 1-3 小时 新手友好度 72/100
-
难度 2/5 1-3 小时 新手友好度 70/100
flatironinstitute/numbl#65 ·