FeatureCollection.fromJson() should also accept a 'Reader' parameter
还没有人认领这个 Issue。
评估
调研方向
阅读 services-geojson/src/main/java/com/mapbox/geojson/FeatureCollection.java 和现有的 fromJson(String) 入口点。使用所示的 Gson 适配器设置添加 Reader 重载,然后运行相关的项目测试,并确认 Reader 输入会生成 FeatureCollection,同时不改变现有的 String 行为。
由索引模型根据 Issue 内容生成。
描述
Currently a FeatureCollection can not be instantiated from a Reader.
The only function provided requires a String in JSON format as can be seen here.
Such approach is inefficient when reading larger files since the entire file content has to be read and stored in memory before it can be transformed into a FeatureCollection.
If a FeatureCollection could be instantiated from a Reader aswell, only parts of the read file would have to be stored in memory which makes this the more desirable approach in the presented situation.
As the used GSON library already enables the use of a Reader instead of a String, the implementation would be very simple and could look like this:
@Nullable
public static FeatureCollection fromJson(@NonNull Reader reader) {
GsonBuilder gson = new GsonBuilder();
gson.registerTypeAdapterFactory(GeoJsonAdapterFactory.create());
gson.registerTypeAdapterFactory(GeometryAdapterFactory.create());
return gson.create().fromJson(reader, FeatureCollection.class);
}
- 主要语言
- Java
- 星标
- 438
- 派生
- 117
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
mapbox/mapbox-java 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
mapbox/mapbox-java#1640 ·
-
难度 4/5 3-5 天 新手友好度 55/100
mapbox/mapbox-java#1635 ·
-
难度 5/5 一周以上 新手友好度 15/100
mapbox/mapbox-java#1619 ·
-
Mapbox-java incompatible with gson 2.13.0 and up - call to internal GSON classes that were renamed 未关闭
难度 2/5 1-3 小时 新手友好度 48/100
mapbox/mapbox-java#1614 · 2 条评论 · 1 个 reaction ·
-
难度 5/5 一周以上 新手友好度 20/100
mapbox/mapbox-java#1612 · 1 个 reaction ·
查看 mapbox/mapbox-java 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 75/100
elastic/gradle-plugins#157 ·
-
enhancement Tools
难度 1/5 1 小时以内 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100
apache/rocketmq-dashboard#5008 ·
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
-
DETECT_PARAMETER_NAMES=false silently disables @ConstructorProperties-based Creator detection too 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
FasterXML/jackson-databind#6229 ·