ChatAgent: don't clobber :rate_limited/:auth_expired on stream_done/error

未关闭
#40 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
elixir
领域
backend

调研方向

从 lib/loopyard/chat_agent.ex 的第 1130、1462 和 821 行附近开始,然后检查 harness/claude.ex:12,以追踪关联 session、stream task 和 stop task 的生命周期。重现或测试延迟 EXIT 场景,并确认来自已替换 session 的 EXIT 会保持当前 session 完整,不会使 CLI 成为孤儿。

由索引模型根据 Issue 内容生成。

描述

bug reliability

Problem

The {:EXIT, pid, reason} handler ignores which process died.

  • lib/loopyard/chat_agent.ex:1130 — handle_info({:EXIT, _pid, reason}, %{status: :thinking}) discards the pid. Sessions are linked (harness/claude.ex:12), as are the warm-interrupt Task.async (chat_agent.ex:1462) and the compaction stop task (chat_agent.ex:821).

Scenario: CLI dies mid-turn → stream Task sends {:stream_error, …, "CLI session exited"} → on_stream_error synchronously restarts the session and drains pending → new turn is :thinking on the new session. The old session's abnormal {:EXIT, …} then arrives, matches the :thinking clause → agent enters :backoff, stashes retry_from_session: state.session (the new, healthy session), so the audit-2 guard passes → handle_retry replaces the healthy session, appends a phantom "Session crashed" message, and the replaced-but-alive CLI is never stopped (only its Resources tracking is released) → ~200MB orphan. Meanwhile the in-flight stream still carries a matching stream_ref and keeps mutating state after handle_retry set :idle.

Fix

Match the EXIT pid against the current stream-task / session pids. Treat an unrelated EXIT like the :normal clause (ignore). Only react to an EXIT from the current session.

Acceptance

  • A late EXIT from a replaced session does not replace the current healthy session and does not orphan a CLI.
主要语言
Elixir
星标
85
派生
11
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

loopyard/loopyard 的其他 Issue

查看 loopyard/loopyard 的全部 Issue

相似的 Issue

更多 Elixir Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。