Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

JavaFilterExampleTest.java fails due to ContextImpl argument count

未关闭
#21 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
1/5
预计耗时
1 小时以内
新手友好度
45/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
java
领域
backend

调研方向

Inspect src/test/java/org/logstashplugins/JavaFilterExampleTest.java, especially the ContextImpl construction in testJavaExampleFilter. Compile the test suite and confirm the constructor call matches the available ContextImpl signature; done means the test sources compile without the argument-count error.

由索引模型根据 Issue 内容生成。

描述

After managing to get tests to run with the PR in #20, I found that with Logstash 7.9 (not sure where this change actually came about), the tests fail to run:

> Task :compileTestJava FAILED
/workspaces/logstash-filter-java_filter_example/src/test/java/org/logstashplugins/JavaFilterExampleTest.java:22: error: constructor ContextImpl in class ContextImpl cannot be applied to given types;
        Context context = new ContextImpl(null);
                          ^
  required: DeadLetterQueueWriter,Metric
  found: <null>
  reason: actual and formal argument lists differ in length
1 error

The Javadocs (harvested from the Logstash source code) list only the following constructor:

ContextImpl(DeadLetterQueueWriter dlqWriter, Metric metric) 

The following diff resolves the issue, I guess either the DeadLetterWriter or the Metrics argument was added, perhaps at the time of GA.

[builder@e4261c43934e logstash-filter-java_filter_example]$ git diff
diff --git a/src/test/java/org/logstashplugins/JavaFilterExampleTest.java b/src/test/java/org/logstashplugins/JavaFilterExampleTest.java
index aee8e2a..99ce06d 100644
--- a/src/test/java/org/logstashplugins/JavaFilterExampleTest.java
+++ b/src/test/java/org/logstashplugins/JavaFilterExampleTest.java
@@ -19,7 +19,7 @@ public class JavaFilterExampleTest {
     public void testJavaExampleFilter() {
         String sourceField = "foo";
         Configuration config = new ConfigurationImpl(Collections.singletonMap("source", sourceField));
-        Context context = new ContextImpl(null);
+        Context context = new ContextImpl(null, null);
         JavaFilterExample filter = new JavaFilterExample("test-id", config, context);
 
         Event e = new org.logstash.Event();
主要语言
Java
星标
19
派生
39
PR 合并指标
30 天内没有已合并 PR

贡献指南

打开贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

logstash-plugins/logstash-filter-java_filter_example 的其他 Issue

查看 logstash-plugins/logstash-filter-java_filter_example 的全部 Issue

相似的 Issue

更多 Java Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。