Reading a field of a class declared later in the file loses its refinement
维护者通常 1 天内回复
已经有一个关联 PR 被合并了。
- #325 来自 @rcosta358 —— 已合并
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 62/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- java
- 领域
- compilers, testing-qa
调研方向
Start with RefinementTypeChecker.visitCtField and visitCtFieldRead, which the issue identifies as the source-order context handling path. Use the supplied ReadBefore reproducer to confirm the false “not enough information” error, then compare it with the version where Job is declared earlier. Done means the reproducer reports “Correct! Passed Verification.” and reads still work when the class is declared later.
由索引模型根据 Issue 内容生成。
描述
Description
Reading a field of an object whose class is declared later in the file does not pick up the field's refinement, so a correct program fails with a false "not enough information" error. Writes to such fields are handled by #314 (fixing #308); reads are not.
Minimal reproducer
import liquidjava.specification.Refinement;
public class ReadBefore {
private final Job job = new Job();
@Refinement("_ >= 0")
public int get() { return job.port; }
static class Job { @Refinement("_ >= 0") int port; }
}
Expected
Correct! Passed Verification.
Actual
Refinement Error: true is not a subtype of #ret² >= 0
5 | public int get() { return job.port; }
| ^^^^^^^^^^^^^^^^
--> Not enough information to prove the expected refinement. Add a refinement or condition to constrain it.
Moving Job above get makes it pass.
Cause
Fields enter the context only in the second pass (RefinementTypeChecker.visitCtField), in source order. When job.port is read, this#port is not in context yet, so visitCtFieldRead falls through to new Predicate() (no information).
Reproduced on main at fbfb4e23 (liquidjava-verifier 0.0.35), and on the #314 branch.
- 主要语言
- Java
- 星标
- 67
- 派生
- 36
- 平均合并
- 2 天 9 小时
- 30 天内合并 PR
- 24
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
liquid-java/liquidjava 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
liquid-java/liquidjava#321 ·
维护者通常 1 天内回复
-
Soundness: try/catch is checked as if the catch block always runs可能已有人在做 @CatarinaGamboa 今天认领。 未关闭bug
难度 4/5 3-5 天 新手友好度 50/100
liquid-java/liquidjava#364 ·
维护者通常 1 天内回复
-
bug
难度 4/5 3-5 天 新手友好度 66/100
liquid-java/liquidjava#360 ·
维护者通常 1 天内回复
-
External specs do not reach user subclasses: a typestate call on a subclass receiver crashes with a sort mismatch可能已有人在做 @CatarinaGamboa 于 1 天前认领。 未关闭bug
难度 4/5 3-5 天 新手友好度 35/100
liquid-java/liquidjava#353 ·
维护者通常 1 天内回复
-
bug
难度 4/5 1-2 天 新手友好度 55/100
liquid-java/liquidjava#349 ·
维护者通常 1 天内回复
查看 liquid-java/liquidjava 的全部 Issue
相似的 Issue
-
status: team-only type: dependency-upgrade
难度 2/5 1-3 小时 新手友好度 65/100
spring-projects/spring-boot#52099 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 67/100
tchiotludo/akhq#3307 · 1 个 reaction ·
维护者通常 1 天内回复
-
status: waiting-for-triage type: bug
难度 2/5 1-3 小时 新手友好度 78/100
spring-projects/spring-security#19847 ·
维护者通常 1 天内回复
-
architecture
难度 2/5 1-3 小时 新手友好度 82/100
DiegoMicali/MovieFlix#16 ·
-
Bug Unverified
难度 2/5 1-3 小时 新手友好度 64/100
维护者通常 1 天内回复