Getting Favicon for pages with redirects like maps.google.com fails

未关闭
#349 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
backend

调研方向

Read the favicon grabber entry point and the related issue #340 to understand how redirects are handled. Compare the current result for maps.google.com with the proposed Google Favicons API approach; the issue says a merge request is already in progress. Done means Maps pages return the Maps favicon instead of the generic Google icon, with the approach agreed on and covered by a check.

由索引模型根据 Issue 内容生成。

描述

When trying to download the Favicon for maps.google.com, it doesn't find the Maps icon. Instead it shows the generic Google icon.

The problem seems to be with Google's redirect to their cookie consent page, which has a generic Google Favicon. The grabber thinks it is the requested site and returns that icon.

A possible fix is incorporating the Google Favicons API, which bypasses such problems if you pass the direct URL into it. I am aware that Google is not really an Open-Source friendly company, but I believe that the simplicity and reliability of their API make the usage worth it. Of course this not being fitting from an ideological standpoint is totally valid. The API does not seem to have any license denying use in other projects. I am working on a merge request to add that feature currently.

related to https://github.com/linuxmint/webapp-manager/issues/340

主要语言
Python
星标
1k
派生
132
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

linuxmint/webapp-manager 的其他 Issue

查看 linuxmint/webapp-manager 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。