Linux: `setPosition` and `setAlignment` cancel a `setSize` call that comes before them

未关闭 适合新手
#37 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
73/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
dart, flutter
领域
desktop

调研方向

从 lib/src/legacy/window_manager.dart 开始,将 setPosition 与 setBounds 一起阅读;报告指出,读取过时的边界值可能会覆盖待处理的尺寸更改。检查附带的 window_manager-setposition-fix.patch,并使用提供的 Flutter 应用在 Linux 上复现调用顺序。在 setSize 后设置位置仍能保留所请求的 1920 × 1080 尺寸时,即为完成;报告称其提出的修复已通过手动检查。

由索引模型根据 Issue 内容生成。

描述

(This issue report is AI-generated)

Summary

On Linux, the legacy call windowManager.setPosition(...) can cancel a
windowManager.setSize(...) call that comes right before it. The methods
setAlignment and center call setPosition, so they have the same problem.

The cause is in lib/src/legacy/window_manager.dart. The setPosition method
calls setBounds(null, position: position). The setBounds method reads
window.bounds (the position and the current size). It changes the position and
writes the whole rectangle to the window.

After a setSize call, the window manager applies the new size a few
milliseconds later. Until then, window.bounds returns the old size. Then
setBounds writes the old size to the window.

I measured a real application (not the repro below) with the same call order.
With 0.5.2, the window was 1920 x 1080.

Scope of the check

  • All measurements come from one machine: a Linux desktop (details below).
  • I did not test other Linux window managers (for example GNOME or KDE), macOS,
    Windows, or Wayland.
  • I ran the repro below exactly as written one time. Seven runs of the repro and
    of a real application, all with the unchanged window_manager, gave the same
    result.

Environment

  • window_manager 0.7.0 (hosted). The code is the same on main (checked 2026-11-16).
  • nativeapi / cnativeapi / nativeapi_flutter 0.6.1
  • Flutter 3.50.0 stable, Dart 3.14.0
  • LMDE 7, X11 session, Cinnamon 6.6.9 (window manager Muffin 6.6.3), GTK 3.24.49
  • The app comes from flutter create --empty --platforms=linux. The runner has
    no changes. It sets gtk_window_set_default_size(window, 1280, 720) and shows
    the window in activate.

Steps to reproduce

  1. Create a new project in an empty folder:
    flutter create --empty --platforms=linux --project-name wm_size_repro .
  2. Add the package: flutter pub add window_manager:0.7.0
  3. Replace the content of lib/main.dart with this code:
// ignore_for_file: deprecated_member_use
import 'package:flutter/widgets.dart';
import 'package:window_manager/legacy.dart';

Future<void> main() async {
  WidgetsFlutterBinding.ensureInitialized();

  await windowManager.ensureInitialized();
  await windowManager.waitUntilReadyToShow(
    const WindowOptions(size: Size(1920, 1080)),
    () async {
      await windowManager.show();
      await windowManager.focus();
    },
  );
  await windowManager.setAlignment(Alignment.topLeft);

  for (var i = 0; i < 12; i++) {
    await Future<void>.delayed(const Duration(milliseconds: 250));
    debugPrint('size=${await windowManager.getSize()}');
  }

  runApp(const Directionality(
    textDirection: TextDirection.ltr,
    child: Center(child: Text('repro')),
  ));
}
  1. Start the app: flutter run -d linux
  2. Read the 12 size= lines in the console.
  3. Find the window: xwininfo -root -tree | grep wm_size_repro
    (The tool xwininfo is in the package x11-utils.)
  4. Measure the window: xwininfo -id <window id>
    Use the id of the entry with the large size. Do not use the 10x10 entries.

Expected

The window is 1920 x 1080 and sits at the top-left of the work area.
(A real application gave this result with 0.5.2.)

Actual

All 12 size= lines show Size(1280.0, 752.0). The real X window is
1280 x 720, at x 2160 and y 467 (the top-left of the work area).

The getSize() value is 32 px higher than the X window. This is probably the
title bar of the window manager. I did not measure the title bar.

What I measured

The table shows the real window size from xwininfo. All rows come from the
same machine and the same app.

Calls Window
setSize, show, focus, then setAlignment(topLeft) (the repro above) 1280 x 720 (wrong)
The same calls without setAlignment 1920 x 1080
setAlignment(topLeft) first, then setSize, show, focus 1920 x 1080 at the top-left
Failing order, with a 300 ms wait before setAlignment 1920 x 1080
Native API only: Window.setSize(...), then Window.position = ... in the same turn 1920 x 1080
The repro above with the patch below 1920 x 1080 at the top-left

nativeapi main (commit 17922b4, 2026-11-16) gives the same wrong result.
For this test, I made a one-line change to window_manager main (a new case
for WindowScaleFactorChangedEvent in a switch) so that the code compiles.
Thus the problem is not in nativeapi.

I first suspected nativeapi. I changed Window::SetPosition there to repeat
the last resize after the move. The window stayed at the wrong size, so that
was the wrong place.

Cause

Future<void> setPosition(Offset position, {bool animate = false}) async {
  await setBounds(null, position: position, animate: animate);
}

Future<void> setBounds(Rect? bounds, {Offset? position, Size? size, bool animate = false}) async {
  ...
  final current = window.bounds.toRect();          // old size, not applied yet
  final target = bounds ?? Rect.fromLTWH(
    position?.dx ?? current.left,
    position?.dy ?? current.top,
    size?.width ?? current.width,                  // old width
    size?.height ?? current.height,                // old height
  );
  ...
  window.bounds = target.toNative();               // writes the old size
}

The package documentation, in the section "Upgrading from 0.5.x", says:
"Geometry changes on platforms without native frame animation are immediate."
Thus the code can expect that a size change is in effect when the next call
reads it. On Linux (X11), this is not true. The window manager applies the size
a few milliseconds later, and window.bounds returns the old size until then.

Suggested fix

When animate is false, move only the position:

Future<void> setPosition(Offset position, {bool animate = false}) async {
  final window = _target;
  if (window == null) return;
  if (!animate) {
    window.position = position.toNative();
    return;
  }
  await setBounds(null, position: position, animate: animate);
}

The patch is in the file window_manager-setposition-fix.patch. I tested it by
hand on Linux (X11) with the repro above. I did not write a unit test.

Not tested

  • macOS, Windows, Wayland, and other Linux window managers. The setBounds
    method reads the size and writes it back on all platforms. It causes a problem
    only if the window manager applies setSize after the next call reads the
    size. I do not know which platforms do this.
  • The animated case (animate: true). The patch does not change it.

Work-around for apps

Call setAlignment or setPosition before the size request. This is safe for
a top-left position, because the position does not depend on the window size.
In my tests (the third row of the table), this order gave 1920 x 1080.

主要语言
TypeScript
星标
186
派生
16
平均合并
1 小时 45 分钟
30 天内合并 PR
5

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

libnativeapi/nativeapi 的其他 Issue

查看 libnativeapi/nativeapi 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。