1.3.2 fix has caused dismissal pane to overflow now

未关闭
#366 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
28/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
dart, flutter
领域
frontend, mobile

调研方向

The body quotes a snippet that wraps an Align in a ClipRect and switches on value == 1; find that code in the repository by searching for clipBehavior, then read the git history of the 1.3.2 change that removed the conditional. Reproduce the left-side overflow by dragging a dismissible tile outside its ListView. Done means the tile stays clipped in that case and the change does not reintroduce the problem the 1.3.2 fix addressed.

由索引模型根据 Issue 内容生成。

描述

A fix was recently implemented in 1.3.2 to remove clipBehavior: value == 1 ? Clip.none : Clip.hardEdge

But this has now resulted in the tile overflowing on the left when dragged outside of the ListView it's placed inside - I think we need to use Clip.hardEdge to prevent this.

Is there an issue with just doing this?

final align = Align(
      alignment: alignment,
      heightFactor: axis == Axis.vertical ? value : null,
      widthFactor: axis == Axis.horizontal ? value : null,
      child: child,
    );

    // if (value == 1) {
    //   // We don't want to clip our child in normal conditions.
    //   return align;
    // }

    // We can't use ClipBehavior.none on Flutter versions < 3.
    return ClipRect(
      clipBehavior: Clip.hardEdge, <------ THIS SOLVES THE ISSUE
      child: align,
    );
主要语言
Dart
星标
2.9k
派生
646
平均合并
5 分钟
30 天内合并 PR
9

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

letsar/flutter_slidable 的其他 Issue

查看 letsar/flutter_slidable 的全部 Issue

相似的 Issue

更多 Dart Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。