Penalize peers whose fetched data column sidecars fail the chain checks

未关闭
#815 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 6 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
47/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
rust

调研方向

Start with crates/net/p2p/src/beacon/column_checks.rs and the two response handlers in crates/net/p2p/src/req_resp/handlers.rs named in the issue. Trace how check verdicts reach those handlers, then read the existing peer reporting or suspicion and backoff paths. Done means a forged column from a by-root response reports its serving peer, with a test asserting that result.

由索引模型根据 Issue 内容生成。

描述

The problem. A DataColumnsByRoot or DataColumnsByRange answer goes through column_checks::check_and_forward (crates/net/p2p/src/beacon/column_checks.rs:322), which takes no PeerId. Both response handlers know the peer and drop it at the call:

  • handle_data_column_sidecars_range_response (crates/net/p2p/src/req_resp/handlers.rs:2466, call at :2505);
  • handle_data_column_sidecars_response (handlers.rs:2530, call at :2567).

A fetched sidecar can be refused on KZG proofs, inclusion proof, header signature, proposer or shape. Such a sidecar is counted in lean_data_columns_rejected_total and nothing else. The peer that served it is not scored, disconnected or deprioritized. Column lookups pick peers at random on retry, so a peer serving forged columns stays as likely to be asked again as any other.

The cost today. Each forged column costs the node CPU. lambdaclass/ethlambda#754 verifies a block's columns in KZG sub-batches of at most 16 and re-checks a failed batch column by column. One forged column per sub-batch then costs about 64 ms of CPU per 16 columns at 9 blobs, against about 51 ms for checking them one at a time as main did. Both figures are computed from measured single-thread batch timings. That is bounded, but nothing stops it repeating.

Why it is out of #754's scope. The gap predates the PR: main's per-sidecar checks did not penalize the sender either. #754 changes how the checks are paid for, not what happens to the source.

What a fix would look like.

  • Carry the source of a check_and_forward call into the group's verdicts: a peer for req/resp answers, and gossip, parked replay or this node's own for the rest.
  • On a Reject outcome from a peer's answer (not an Ignore, and not a parked replay, whose original sender is long gone), report that peer. That could mean a disconnect, or the same suspicion and backoff range sync applies to peers that serve bad data, so it is not asked again for a while.
  • A test can feed a forged column through a fake by-root answer and assert the peer is reported.

Related. lambdaclass/ethlambda#803 (open) holds a refused sidecar against its sender for the rest of that one by-root lookup, so the lookup stops asking that peer. It does not score the peer or carry over to later lookups.

主要语言
Rust
星标
86
派生
34
平均合并
9 天 20 小时
30 天内合并 PR
77

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

lambdaclass/ethlambda 的其他 Issue

查看 lambdaclass/ethlambda 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。